This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
output-swapchain: new helper #3197
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bl4ckb0ne
reviewed
Sep 15, 2021
types/wlr_output_swapchain.c
Outdated
| return NULL; | ||
| } | ||
|
|
||
| manager->renderer = wlr_renderer_autocreate(backend); |
There was a problem hiding this comment.
Should the helper "own" the renderer? wlr_backend_get_renderer seems more appropriate for external renderers.
There was a problem hiding this comment.
I want to get rid of wlr_backend_get_renderer eventually, because the backend should be completely separate from the renderer.
emersion
force-pushed
the
output-render
branch
from
bce2ea9
to
0c00087
Compare
This does the same as wlr_output_damage_attach_render except it doesn't call wlr_output_attach_render.
emersion
force-pushed
the
output-render
branch
from
0c00087
to
98db759
Compare
|
wlroots has migrated to gitlab.freedesktop.org. This pull request has been moved to: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3197 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wlr_output_damagewlr_outputCloses: #3079