Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to do it
The process of refactoring is very mechanical and labor intensive:
Effectiveness
I have almost finished
swc_ecma_ast
,swc_ecma_parser
andswc_ecma_visit
crates. You can run the benchmark withcargo bench -p swc_ecma_parser --bench arena_compare
:Existing Barriers
When I was refactoring the parser, I found the following steps to be very mechanical and cumbersome. I think it will greatly reduce the developer enthusiasm for refactoring codebase and downstream applications.
Into
.AstNode::default()
Box::new_in(.., self.alloc)