Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 673: Add title and just year as x-axis label #691

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

nikk-nikaznan
Copy link
Contributor

Issue #673

Extract the years from the columns (so instead of gdpPercap_<year> will just be the year), and add title to the plot as GDP Per Capita for Regions Over Time.

Copy link

github-actions bot commented Dec 3, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/python-novice-gapminder/compare/md-outputs..md-outputs-PR-691

The following changes were observed in the rendered markdown documents:

 14-looping-data-sets.md | 12 ++++++++++--
 md5sum.txt              |  2 +-
 2 files changed, 11 insertions(+), 3 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-12-03 11:01:33 +0000

github-actions bot pushed a commit that referenced this pull request Dec 3, 2024
@vahtras
Copy link
Contributor

vahtras commented Dec 3, 2024

Thanks. This change to the suggested solution is not directly visible in the workshop material but if one downloads the code and generates the graph one will see be a substantial improvement: avoiding ugly overlapping x-labels. There is nothing to question here so I will accept it.

@vahtras vahtras merged commit 18b7d60 into swcarpentry:main Dec 3, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 3, 2024
Auto-generated via `{sandpaper}`
Source  : 18b7d60
Branch  : main
Author  : Olav Vahtras <[email protected]>
Time    : 2024-12-03 12:07:30 +0000
Message : Merge pull request #691 from nikk-nikaznan/673-axis-labels

Issue 673: Add title and just year as x-axis label
github-actions bot pushed a commit that referenced this pull request Dec 3, 2024
Auto-generated via `{sandpaper}`
Source  : bc731ac
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-12-03 12:08:18 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 18b7d60
Branch  : main
Author  : Olav Vahtras <[email protected]>
Time    : 2024-12-03 12:07:30 +0000
Message : Merge pull request #691 from nikk-nikaznan/673-axis-labels

Issue 673: Add title and just year as x-axis label
github-actions bot pushed a commit that referenced this pull request Dec 10, 2024
Auto-generated via `{sandpaper}`
Source  : bc731ac
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-12-03 12:08:18 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 18b7d60
Branch  : main
Author  : Olav Vahtras <[email protected]>
Time    : 2024-12-03 12:07:30 +0000
Message : Merge pull request #691 from nikk-nikaznan/673-axis-labels

Issue 673: Add title and just year as x-axis label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants