Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update character.json #4

Closed
wants to merge 2 commits into from
Closed

Update character.json #4

wants to merge 2 commits into from

Conversation

vandana1499
Copy link
Contributor

#3 Updated the character.json with new character in the schema

@swetankraj
Copy link
Owner

Thank you for your contribution @vandana1499 , though everything is fine,

  • could you please update img data url till .jpg.
  • in portrayed Adult and Old character is mismatched. Just do a google search. Adult is Oliver and Old is Winfried.

Correct these 2 things, I'll be happily merging them then.

@vandana1499
Copy link
Contributor Author

Ok, I will make changes.

@vandana1499 vandana1499 mentioned this pull request Sep 9, 2020
Merged
@swetankraj swetankraj closed this Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vandana1499 @swetankraj