Create infrastructure to separate Foundation into multiple modules; move all code into FoundationBase module. #1799
Conversation
Required for the work in swiftlang/swift-corelibs-foundation#1799
|
Please test with the following: @swift-ci please test |
|
Please test with the following: @swift-ci please test |
Foundation/Foundation.swift
Outdated
|
|
||
| import CoreFoundation | ||
|
|
||
| #if DEPLOYMENT_RUNTIME_SWIFT && canImport(Darwin) |
There was a problem hiding this comment.
Isn't this due to the ObjC Foundation existing and not specific to Darwin? Can we not do something like @_runtime(_ObjC) here? :-(
There was a problem hiding this comment.
I’ve tried really hard to confine private attributes elsewhere, but it is correct that the one you point is the most relevant condition.
|
Please test with the following: @swift-ci please test |
3 similar comments
|
Please test with the following: @swift-ci please test |
|
Please test with the following: @swift-ci please test |
|
Please test with the following: @swift-ci please test |
Required for the work in swiftlang/swift-corelibs-foundation#1799
|
Please test with the following: @swift-ci please test |
1 similar comment
|
Please test with the following: @swift-ci please test |
|
Unsure why the clang patch isn't being picked up. |
|
Please test with the following: @swift-ci please test |
|
The macOS crash is suspect, but unclear if patch-related. |
Required for the work in swiftlang/swift-corelibs-foundation#1799
|
Rebased onto master to ensure this isn't hitting a since-fixed bug. |
|
Please test with the following: @swift-ci please test |
|
I don't see this crash without my patch; building on macOS to check. |
|
Please test with the following: @swift-ci please test |
millenomi
changed the title
This commit moves all of {Swift,}Foundation into a separate module named {Swift,}FoundationSoil, including the Core Foundation symbols, and then creates a new {Swift,}Foundation module that re-exports Soil so that `import {Swift,}Foundation` clients can continue working correctly. **The module name isn’t final; do not use it.**
Future split work can define multiple modules this way by copying the approach in both the Xcode project and the CMake setup.
This requires a coordinated clang change.
|
The Swift project moved the default branch to More detail about the branch update - https://forums.swift.org/t/updating-branch-names/40412 |
This commit moves all of {Swift,}Foundation into a separate module named {Swift,}FoundationSoil, including the Core Foundation symbols, and then creates a new {Swift,}Foundation module that re-exports Soil so that
import {Swift,}Foundationclients can continue working correctly. The module name isn’t final; do not use it.Future split work can define multiple modules this way by copying the approach in both the Xcode project and the CMake setup.
This requires a coordinated clang change (forthcoming).