Add comprehensive set of NumberingSystem constants #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glebfann
commented
Nov 21, 2024
| @@ -508,8 +508,6 @@ extension Locale { | |||
| _normalizedIdentifier = identifier.lowercased() | |||
| } | |||
|
|
|||
| package static let latn = NumberingSystem("latn") | |||
There was a problem hiding this comment.
Since this is not a public declaration, I decided to rename it and declare it along with other variables
|
Thanks for the PR! This change adds public symbols, so we'd want to draft a proposal according to the Evolution process. Let me know if I can help in anyway |
Thank you! I apologize for missing this - I have created PR with the proposal: #1061 |
glebfann
force-pushed
the
add-numbering-system-constants
branch
3 times, most recently
from
5b8e8ff to
d350efb
Compare
glebfann
force-pushed
the
add-numbering-system-constants
branch
from
d350efb to
c7e1f7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds static constants for all supported numbering systems as defined in number.xml, addressing issue #1052