Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use async HTTPClient in RegistryClient #8089

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from
Draft

Use async HTTPClient in RegistryClient #8089

wants to merge 32 commits into from

Conversation

MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented Nov 1, 2024 •
edited
Loading

Motivation:

To adopt Swift concurrency in ManifestLoader, we need to convert RegistryClient first, which then would require use of HTTPClient instead of LegacyHTTPClient.

Modifications:

Converted (and as a consequence, simplified) code in RegistryClient.

Result:

One major previous adopter of LegacyHTTPClient is now compatible with Swift concurrency.

1000+ lines of code removed.

Since RegistryClient was blocking Swift concurrency thread pool and also used .sharedConcurrent dispatch queue, this potentially fixes thread explosion/deadlocks that may have been caused by previously broken code.

@MaxDesiatov
Fix recursion deadlock in RegistryPackageContainer, cleanup warnings
6731eb5
@MaxDesiatov
Add async withLock to InMemoryFileSystem
085bad1
@MaxDesiatov
Make sure Workspace.loadRootManifests doesn't throw
7cc81af
@MaxDesiatov
Don't duplicate Diagnostics.fatalError in diagnostics
ad8b612
@MaxDesiatov
Fix InMemoryFileSystem.withLock deadlock
4c00304
@MaxDesiatov
Fix formatting in Workspace+Manifests.swift
5890073
@MaxDesiatov
Document new ThreadSafeBox.mutate overload
d91c0f8
@MaxDesiatov
Fix remaining WorkspaceRegistryTests failures
c12aff1
@MaxDesiatov
Clean up formatting
4f443d0
@MaxDesiatov
Fix up formatting
c204af2
@MaxDesiatov
Merge branch 'main' of github.com:swiftlang/swift-package-manager int…
80f54a8 
…o maxd/async-registry-client

# Conflicts:
#	Sources/Basics/Concurrency/ThreadSafeBox.swift
#	Tests/WorkspaceTests/WorkspaceTests.swift
@MaxDesiatov
Refactor some of RegistryDownloadsManagerTests for Swift concurrency
885f314
@MaxDesiatov
Fix most of RegistryDownloadsManagerTests
83355bf
@MaxDesiatov
Fix RegistryDownloadsManagerTests.testConcurrency
0e159d9
@MaxDesiatov MaxDesiatov added the bug label Nov 5, 2024
@MaxDesiatov MaxDesiatov self-assigned this Nov 5, 2024
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov MaxDesiatov mentioned this pull request Nov 6, 2024
Draft
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test macos

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test windows

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham will be requested when the pull request is marked ready for review bnbarham is a code owner

@jakepetroules jakepetroules Awaiting requested review from jakepetroules jakepetroules will be requested when the pull request is marked ready for review jakepetroules is a code owner

@francescomikulis francescomikulis Awaiting requested review from francescomikulis francescomikulis will be requested when the pull request is marked ready for review francescomikulis is a code owner

@xedin xedin Awaiting requested review from xedin xedin will be requested when the pull request is marked ready for review xedin is a code owner

@dschaefer2 dschaefer2 Awaiting requested review from dschaefer2 dschaefer2 will be requested when the pull request is marked ready for review dschaefer2 is a code owner

@shawnhyam shawnhyam Awaiting requested review from shawnhyam shawnhyam will be requested when the pull request is marked ready for review shawnhyam is a code owner

@bripeticca bripeticca Awaiting requested review from bripeticca bripeticca will be requested when the pull request is marked ready for review bripeticca is a code owner

@plemarquand plemarquand Awaiting requested review from plemarquand plemarquand will be requested when the pull request is marked ready for review plemarquand is a code owner

@owenv owenv Awaiting requested review from owenv owenv will be requested when the pull request is marked ready for review owenv is a code owner

@bkhouri bkhouri Awaiting requested review from bkhouri bkhouri will be requested when the pull request is marked ready for review bkhouri is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@MaxDesiatov MaxDesiatov

Labels
bug concurrency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MaxDesiatov