tests: Run tests on Linux CI #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euanh
force-pushed
the
enable-linux-ci
branch
from
f45cd4c to
7e463a4
Compare
|
@swift-ci test |
|
Expect the first run to fail |
euanh
force-pushed
the
enable-linux-ci
branch
from
7e463a4 to
542d515
Compare
|
@swift-ci test |
…nEssentials.URL Until Swift 6.0, the fully-qualified name of the URL type was `Foundation.URL`. After the adoption of FoundationEssentials, the name changed to `FoundationEssentials.URL`. This difference causes the hashes to change, so for backwards compatibility we pin the type name to `Foundation.URL`. Fixes swiftlang#45
euanh
force-pushed
the
enable-linux-ci
branch
from
96eecce to
1c609f3
Compare
|
@swift-ci test |
euanh
force-pushed
the
enable-linux-ci
branch
from
1c609f3 to
f76acec
Compare
The EndToEnd tests cannot currently be run: * they deadlock when run under `swift test` (swiftlang#143) * the CI requires the use of an HTTP proxy to download from the Internet, but SDK generator does not support proxies (swiftlang#145) The tests are not compiled on macOS, but this commit marks them with `XCTSkip` so they are not run on Linux either. Future commits will loosen these restrictions. Fixes swiftlang#45
euanh
force-pushed
the
enable-linux-ci
branch
from
f76acec to
95b78b4
Compare
|
@swift-ci test |
MaxDesiatov
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EndToEnd tests cannot currently be run:
swift test(EndToEndtests deadlock when run at the command line withswift test#143)Until now the tests were not compiled on macOS, and the tests were not run on Linux, so CI runs did not deadlock. This PR marks the tests with
XCTSkipto prevent them running in CI or when run locally; future PRs will loosen these restrictions.testQueryEncodingfailed onmainbecauseFoundation.URLhad changed toFoundationEssentials.URL, causing cache hashes to be different. This PR ensures backward compatibility by overriding the type name used when hashingURLs to beFoundation.URL.Fixes #45