[SwiftLexicalLookup] Add unqualified lookup rules documentation. #2849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
reviewed
Sep 16, 2024
| # Unqualified Lookup Rules | ||
|
|
||
| ## Overview | ||
| Unqualified lookup can be initiated from any source position, optionally targeting a specific identifier for name comparison. Unqualified lookup traverses the syntax tree from bottom-up, collecting names that match the lookup criteria. A name matches the lookup if the specified identifier (if present) refers to the introduced name and the position from which the unqualified lookup was triggered is preceded by the position where the name was introduced (if specified). |
There was a problem hiding this comment.
and the position from which the unqualified lookup was triggered is preceded by the position where the name was introduced (if specified)
This isn’t technically true because types can be defined after the lookup position, right?
There was a problem hiding this comment.
I tried to indicate it by having (if specified) by the end of the sentence, but I agree it was a bit ambiguous. I revised the ending.
Sources/SwiftLexicalLookup/SwiftLexicalLookup.docc/LookupRules.md
Outdated
Show resolved
Hide resolved
Sources/SwiftLexicalLookup/SwiftLexicalLookup.docc/LookupRules.md
Outdated
Show resolved
Hide resolved
Sources/SwiftLexicalLookup/SwiftLexicalLookup.docc/LookupRules.md
Outdated
Show resolved
Hide resolved
ahoppen
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a documentation article describing in high level SwiftLexicalLookup name lookup rules as well as more detailed dive into each of the scopes.