[6.0] Add cross-compiling support for the windows toolchain #73920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahmishal
changed the title
|
@swift-ci test |
Future work to enable Android SDKs requires fetching additional dependencies (e.g. Android NDK). Refactor the fetch dependencies method to allow us to share the download logic rather than replicating it for each piece. This will also allow us to fetch the Python dependency for the ARM64 toolchain cross-compilation. (cherry picked from commit 726bf5c)
|
@swift-ci test windows |
|
@swift-ci test macOS |
|
@swift-ci test Linux |
|
git log --oneline --no-merges origin/release/6.0..origin/main -- utils/build.ps1 Need to cherry-pick following commits to enable arm64 support on Windows for release/6.0 branch:
@compnerd Do we need any of the following commits in release/6.0 and to support arm64?
@rintaro Should we pull this into release/6.0?
Both of these commits were made due to Android support: |
When using the just built compiler, we need to use the build CMark runtime as it is executing on the build. This used to work when host and build were guaranteed to be identical (i.e. no cross-compilation). This is now needed to support cross-compiling ARM64. (cherry picked from commit 421c0cf)
We need to tweak the path before we can use the pinned or the just built toolchain. This becomes a problem when trying to cross-compile the toolchain. (cherry picked from commit 5440760)
Co-authored-by: Mishal Shah <[email protected]> (cherry picked from commit eb6cd28)
|
@swift-ci test |
compnerd
approved these changes
May 27, 2024
DougGregor
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authrored with @compnerd
(cherry picked from commit f6ab729)
Explanation: Bring cross-compiling support for Windows arm64 to release/6.0 branch
Scope: Update the utils/build.ps1 script to include changes required to cross compile for arm64.
Original PRs: #71584, #73058, #73494, #73733
Risk: Low
Testing: Verify the Windows toolchain for arm64 builds
Reviewer: @compnerd