Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0.1][Windows] Teach Build-Testing how to find Foundation #76564

Merged

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Sep 18, 2024

Cherry-pick #76489 into release/6.0.1

  • Explanation: Previously in Windows builds, Testing was not linked to Foundation. Because of that, Testing in Windows toolchains lacked the functionalities. Pass Foundation_DIR to swift-testing CMake configuration so it can find the Foundation's search and link paths.
  • Scope: swift-testing build in Windows toolchains
  • Risk: Low. Obvious build.ps1 only changes
  • Testing: Passes the current test suite. Also manually tested with a PR toolchain
  • Issues: N/A
  • Reviewers: @compnerd @bnbarham

Pass `Foundation_DIR` to the cmake.

(cherry picked from commit ff0f923)
@rintaro rintaro requested a review from a team as a code owner September 18, 2024 23:34
@rintaro rintaro changed the title [Windows] Teach Build-Testing how to find Foundation [6.0.1][Windows] Teach Build-Testing how to find Foundation Sep 18, 2024
@rintaro
Copy link
Member Author

rintaro commented Sep 18, 2024

swiftlang/swift-testing#713
@swift-ci Please test

@shahmishal shahmishal changed the base branch from release/6.0.1 to release/6.0.2 September 20, 2024 05:20
@rintaro
Copy link
Member Author

rintaro commented Sep 20, 2024

swiftlang/swift-testing#713
@swift-ci Please build toolchain Windows

@rintaro rintaro merged commit 572ce7c into swiftlang:release/6.0.2 Sep 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants