Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove swift-indent tool #76577

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Remove swift-indent tool #76577

merged 1 commit into from
Sep 21, 2024

Conversation

compnerd
Copy link
Member

This removes the implementation of the swift-indent tool, its associated documentation, and utilities. This tool was never completed and has much better alternatives with swift-format which is more flexible and actually maintained.

This removes the implementation of the `swift-indent` tool, its
associated documentation, and utilities. This tool was never completed
and has much better alternatives with `swift-format` which is more
flexible and actually maintained.
@compnerd
Copy link
Member Author

@swift-ci please test

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

Copy link
Contributor

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Do we need a matching patch to the driver repo to update the options there?

@compnerd
Copy link
Member Author

Yeah, it would be good to update swift-driver as well.

@compnerd
Copy link
Member Author

@swift-ci please test Linux platform

@compnerd compnerd merged commit dacdb8f into swiftlang:main Sep 21, 2024
5 checks passed
@compnerd compnerd deleted the undent branch September 21, 2024 17:57
allevato added a commit to allevato/swift-driver that referenced this pull request Oct 9, 2024
This is the companion of swiftlang/swift#76872.

I've reused the `SwiftIndentOption` constant, which was removed by
swiftlang/swift#76577 (but Options.swift
was never updated here to remove it).
artemcm pushed a commit to swiftlang/swift-driver that referenced this pull request Oct 18, 2024
This is the companion of swiftlang/swift#76872.

I've reused the `SwiftIndentOption` constant, which was removed by
swiftlang/swift#76577 (but Options.swift
was never updated here to remove it).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants