Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit JSFunction from JSClosure #239

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

kateinoigakukun
Copy link
Member

There is no reason not to make JSClosure to be compatible with JSFunction. We can treat JSClosure as a JSFunction and call it from not only JavaScript but also Swift.

Copy link

github-actions bot commented Apr 7, 2024

Time Change: +495ms (5%) 🔍

Total Time: 9,795ms

Test name Duration Change
Serialization/JavaScript function call through Wasm import 21ms +2ms (11%) ⚠️
Serialization/JavaScript function call through Wasm import with int 15ms +1ms 🔍
Serialization/JavaScript function call from Swift 102ms +5ms (5%) 🔍
Serialization/Swift Int to JavaScript with assignment 342ms +23ms (6%) 🔍
Serialization/Swift Int to JavaScript with call 1,008ms +52ms (5%) 🔍
Serialization/JavaScript Number to Swift Int 312ms +16ms (5%) 🔍
Serialization/JavaScript String to Swift String 3,838ms +217ms (5%) 🔍
View Unchanged
Test name Duration Change
Serialization/Swift String to JavaScript with assignment 391ms +15ms (3%)
Serialization/Swift String to JavaScript with call 1,059ms +44ms (4%)
Object heap/Increment and decrement RC 2,694ms +118ms (4%)
View Baselines
Test name Duration
Serialization/Call JavaScript function directly 3ms
Serialization/Assign JavaScript number directly 3ms
Serialization/Call with JavaScript number directly 4ms
Serialization/Write JavaScript string directly 3ms
Serialization/Call with JavaScript string directly 3ms

There is no reason not to make JSClosure to be compatible with
JSFunction. We can treat JSClosure as a JSFunction and call it
from not only JavaScript but also Swift.
@kateinoigakukun kateinoigakukun force-pushed the katei/inherit-jsf-from-jsc branch from 14e885c to 6ee6772 Compare April 7, 2024 03:48
@kateinoigakukun kateinoigakukun merged commit 3e07fdc into main Apr 7, 2024
17 checks passed
@kateinoigakukun kateinoigakukun deleted the katei/inherit-jsf-from-jsc branch April 7, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant