Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop use of global variable as a object cache #274

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Nov 28, 2024

Fix crash on workers due to use of JSObject referencing main thread objects

Copy link

Time Change: -149ms (1%)

Total Time: 9,611ms

Test name Duration Change
Serialization/JavaScript function call through Wasm import 17ms -8ms (45%) 🎉
Serialization/JavaScript function call through Wasm import with int 14ms +1ms 🔍
Serialization/JavaScript Number to Swift Int 297ms -15ms (5%)
Serialization/Swift String to JavaScript with assignment 384ms -41ms (10%) 👏
View Unchanged
Test name Duration Change
Serialization/JavaScript function call from Swift 109ms -1ms (1%)
Serialization/Swift Int to JavaScript with assignment 333ms -10ms (3%)
Serialization/Swift Int to JavaScript with call 1,033ms -40ms (3%)
Serialization/Swift String to JavaScript with call 1,082ms -29ms (2%)
Serialization/JavaScript String to Swift String 3,685ms +1ms (0%)
Object heap/Increment and decrement RC 2,642ms -7ms (0%)
View Baselines
Test name Duration
Serialization/Call JavaScript function directly 3ms
Serialization/Assign JavaScript number directly 2ms
Serialization/Call with JavaScript number directly 3ms
Serialization/Write JavaScript string directly 3ms
Serialization/Call with JavaScript string directly 2ms

@kateinoigakukun kateinoigakukun merged commit 02a4dda into main Nov 28, 2024
18 checks passed
@kateinoigakukun kateinoigakukun deleted the yt/fix-multithread-cache-issue branch November 28, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant