Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct service tests #21

Merged
merged 1 commit into from
May 29, 2024
Merged

Correct service tests #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions tests/test_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def unreachable_engine_instance_fixture(httpserver: HTTPServer):
def app_with_reachable_engine_instance(reachable_engine_instance: HTTPServer):
def get_settings_override():
settings = get_settings()
settings.engine_urls = reachable_engine_instance.url_for("")
settings.engine_urls = [reachable_engine_instance.url_for("")]
settings.engine_announce_retries = 2
settings.engine_announce_retry_delay = 1
settings.max_tasks = 2
Expand All @@ -83,7 +83,7 @@ def get_settings_override():
def app_with_unreachable_engine_instance(unreachable_engine_instance: HTTPServer):
def get_settings_override():
settings = get_settings()
settings.engine_urls = unreachable_engine_instance.url_for("")
settings.engine_urls = [unreachable_engine_instance.url_for("")]
settings.engine_announce_retries = 2
settings.engine_announce_retry_delay = 1
settings.max_tasks = 2
Expand Down Expand Up @@ -111,10 +111,11 @@ def test_announce_to_reachable_engine(
# This is not a good way to test the app as any other warnings will make the test
# passes.
warning_logs_found = False
# for record in caplog.records:
# if record.levelname == "WARNING":
# warning_logs_found = True
# break
for record in caplog.records:
if record.levelname == "WARNING":
if "Failed to notify the engine" in record.message:
warning_logs_found = True
break

assert not warning_logs_found

Expand All @@ -134,8 +135,9 @@ def test_announce_to_unreachable_engine(
warning_logs_found = False
for record in caplog.records:
if record.levelname == "WARNING":
warning_logs_found = True
break
if "Failed to notify the engine" in record.message:
warning_logs_found = True
break

assert warning_logs_found

Expand Down
Loading