Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card API Review Level 1 #18

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

Conversation

christiangmehling
Copy link

@christiangmehling christiangmehling commented Jun 3, 2024

Goal

In this Pull Request all feedback to the proposed Level 1 of the SFTI Common API Card API is collected. When all feedback is incorporated a version 1.0 of the standard will be published.

Instructions

Please review the files cardInfoAPI-Level1.yaml and operationalGuide.md. The cardInfoAPI.yaml can be ignored.

The cardInfoAPI-Level1.yaml is the Swagger specification. For easier readability you can review the file in the Swagger Editor view: Link

The operationalGuide.md is the markdown version of the Operational Guide. For easier readability you can either select to "Display the rich diff" directly in the Pull Request or in the Wiki (pages in section "API specific Information").

In order to capture a comment on the files please follow the general GitHub instructions here: GitHub Docs - Review proposed changes
You might also be interested in the GitHub Docs section about Comment on a PR or View a PR review.

Note that you can also vote and react to existing comments. Please use this functionality to make it easier for the core team to consolidate the feedback.

Every user with a GitHub login can comment, no special access rights are needed.

Timeline

The review is open until 28th June. The Card API core team will review the received feedback afterwards and seek alignment with individual reviewers where needed.

@christiangmehling christiangmehling requested a review from a team as a code owner June 3, 2024 13:19
@@ -0,0 +1,1402 @@
openapi: 3.1.0
info:
version: 0.7.0
Copy link
Author

@christiangmehling christiangmehling Jun 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear Reviewer

thank you for your valuable feedback. Please provide your feedback on the corresponding point in this file and include your feedback in the follow structure:

  • Title:
  • Question/Feedback:
  • Suggestion for improvement:

Please start with describing your Feedback or asking your Question regarding a specific component in the spec. For overall questions or remarks please use the comment function for the whole file. Make sure your feedback is not collected already, if so, please like the feedback or add further issues or clarifications as reply to the comment.

It might be very helpful if you suggest improvements for the core team to elaborate your feedback. Thus we ask you to share all your relevant thoughts on this topic and feel free to share any solutions to your issue. This will improve further discussion and allow people to refactor your suggestions. The core team will come back to your feedback as needed.

Copy link

@aba-ellinger aba-ellinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the good work.

operationalGuide.md Show resolved Hide resolved
cardInfoAPI-Level1.yaml Show resolved Hide resolved
cardInfoAPI-Level1.yaml Show resolved Hide resolved
cardInfoAPI-Level1.yaml Show resolved Hide resolved
cardInfoAPI-Level1.yaml Outdated Show resolved Hide resolved
cardInfoAPI-Level1.yaml Outdated Show resolved Hide resolved
cardInfoAPI-Level1.yaml Show resolved Hide resolved
cardInfoAPI-Level1.yaml Outdated Show resolved Hide resolved
cardInfoAPI-Level1.yaml Outdated Show resolved Hide resolved
cardInfoAPI-Level1.yaml Show resolved Hide resolved
cardInfoAPI-Level1.yaml Outdated Show resolved Hide resolved
cardInfoAPI-Level1.yaml Show resolved Hide resolved
cardInfoAPI-Level1.yaml Outdated Show resolved Hide resolved
cardInfoAPI-Level1.yaml Outdated Show resolved Hide resolved
Copy link

@MartinRenggli MartinRenggli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is important that the operational guide is solidly defined before APIs are finally defined. Currently, the quality of this guide is not yet sufficient. Some basic clarifications and enhancements are still required before the APIs are addressed. Otherwise, there is a risk that the foundation will need to be improved again and again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants