Skip to content

Commit

Permalink
chore: fix pnpm start command (#3504)
Browse files Browse the repository at this point in the history
This change excludes `@swisspost/design-system-styles` from the vite
optmizeDeps workflow for the documentation package. This seems to get
rid of some of the "can't import dynamic dependency" issues.

Reloading after a style change is still pretty slow, but also a lot of
unnecessry recompiles are happening. The potential for improvement is
quite big here.
  • Loading branch information
gfellerph authored Sep 6, 2024
1 parent 6df326f commit 2dd2915
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions packages/documentation/vite.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,6 @@ export default {
'@storybook/theming',
'@storybook/addon-links',
],
exclude: ['@swisspost/design-system-styles'],
},
};
4 changes: 2 additions & 2 deletions packages/styles/gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ gulp.task('build-components', () => {
*/
gulp.task('sass:dev', () => {
return gulp
.src('./src/*.scss', { since: gulp.lastRun('sass:dev') })
.src('./src/*.scss')
.pipe(
gulpSass({
includePaths: options.includePaths,
Expand Down Expand Up @@ -180,7 +180,7 @@ gulp.task('sass:tests', () => {
gulp.task(
'watch',
gulp.series('temporarily-copy-token-files', () => {
return gulp.watch('./src/**/*.scss', gulp.series('copy'));
return gulp.watch('./src/**/*.scss', gulp.series('copy', 'sass:dev'));
}),
);

Expand Down

0 comments on commit 2dd2915

Please sign in to comment.