Skip to content

Commit

Permalink
chore: move workspace peerDependency to dependencies (#3169)
Browse files Browse the repository at this point in the history
Even if recommended otherwise by the stencil docs
(https://stenciljs.com/docs/angular), to preven major bumps across all
linked workspace packages, we need to try to move the peerDeps to deps
for this one.

---------

Co-authored-by: Oliver Schürch <[email protected]>
  • Loading branch information
gfellerph and oliverschuerch authored Jun 27, 2024
1 parent b8eaddc commit f1209ce
Show file tree
Hide file tree
Showing 4 changed files with 47 additions and 82 deletions.
5 changes: 5 additions & 0 deletions .changeset/olive-knives-marry.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@swisspost/design-system-components-angular': patch
---

Redefined the dependency to the web components package as a dependency instead of a peer dependency due to a [known bug in changesets](https://github.com/changesets/changesets/issues/1011) that causes major version bumps across all linked workspace packages if one of them is installed as a peer dependency.
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
"dest": "../../dist/components",
"lib": {
"entryFile": "src/public-api.ts"
}
}
},
"allowedNonPeerDependencies": ["@swisspost/design-system-components"]
}
6 changes: 3 additions & 3 deletions packages/components-angular/projects/components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@
"linkDirectory": true
},
"dependencies": {
"tslib": "2.6.3"
"tslib": "2.6.3",
"@swisspost/design-system-components": "workspace:7.1.0"
},
"peerDependencies": {
"@angular/common": "^16.0.0 || ^17.0.0",
"@angular/core": "^16.0.0 || ^17.0.0",
"@swisspost/design-system-components": "workspace:7.1.0"
"@angular/core": "^16.0.0 || ^17.0.0"
},
"sideEffects": false
}
113 changes: 36 additions & 77 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit f1209ce

Please sign in to comment.