feat(dialog): adding styles for native dialog #2772

gfellerph · 2024-03-07T15:26:04Z

Styles for the dialog element, replacing ngb-modal.

This is WIP

changeset-bot · 2024-03-07T15:26:08Z

🦋 Changeset detected

Latest commit: 3021bb0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages

Name	Type
@swisspost/design-system-documentation	Minor
@swisspost/design-system-styles	Minor
@swisspost/design-system-components-angular-workspace	Patch
@swisspost/design-system-components	Minor
@swisspost/design-system-demo	Patch
@swisspost/internet-header	Patch
@swisspost/design-system-intranet-header-workspace	Patch
@swisspost/design-system-nextjs-integration	Patch
@swisspost/design-system-styles-primeng-workspace	Patch
@swisspost/design-system-intranet-header	Minor
@swisspost/design-system-styles-primeng	Minor
@swisspost/design-system-components-react	Minor
@swisspost/design-system-components-angular	Minor
@swisspost/design-system-intranet-header-showcase	Patch
@swisspost/design-system-tokens	Minor
@swisspost/design-system-icons	Minor
@swisspost/design-system-migrations	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

swisspost-bot · 2024-03-07T15:27:58Z

Preview environment ready: https://preview-2772--swisspost-web-frontend.netlify.app
Preview environment ready: https://preview-2772--swisspost-design-system-next.netlify.app

gfellerph · 2024-03-07T20:43:48Z

packages/styles/src/components/dialog.scss

+    transform: scale(1);
+    opacity: 1;
+
+    @starting-style {


Both Safari (WebKit/standards-positions#210) and Firefox (mozilla/standards-positions#833) are supportive of the spec, therefore I consider it safe to use for progressive enhancement.

swisspost-bot · 2024-05-29T18:46:18Z

Related Previews

sonarcloud · 2024-05-29T19:22:31Z

Quality Gate failed

Failed conditions
2 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

There will be a new notification concept for Design v2

alizedebray · 2024-08-13T06:41:22Z

@gfellerph Is this still a draft?

gfellerph · 2024-08-13T06:42:45Z

@gfellerph Is this still a draft?

no

socket-security · 2024-08-15T05:56:29Z

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

alizedebray

Nice! Happy to say goodbye to two ngb components at once 🌟

.changeset/popular-games-rush.md

packages/documentation/package.json

packages/documentation/src/stories/components/dialog/dialog.docs.mdx

packages/documentation/src/stories/components/dialog/dialog.stories.ts

packages/documentation/src/stories/components/dialog/dialog.snapshot.stories.ts

packages/styles/src/components/dialog.scss

packages/documentation/src/stories/components/dialog/dialog.stories.ts

Co-authored-by: Alizé Debray <[email protected]>

…cs.mdx Co-authored-by: Alizé Debray <[email protected]>

Co-authored-by: Alizé Debray <[email protected]>

…design-system into 1536-component-dialog

alizedebray

Looks great!
There is only this small display issue with the last example:

sonarcloud · 2024-10-08T14:30:32Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

gfellerph added 4 commits February 29, 2024 14:52

feat(dialog): adds styling and docs

4351f35

This is WIP

Merge branch 'main' into 1536-component-dialog

bf3c120

refactor: animations and dialog part names

3fe243d

Merge branch 'main' into 1536-component-dialog

d5f4a45

gfellerph commented Mar 7, 2024

View reviewed changes

gfellerph added 7 commits March 20, 2024 20:27

Merge branch 'main' into 1536-component-dialog

f332c67

chore: deprecating modal and notification overlay

c9a03db

chore: add changesets

f796576

chore: added code samples

f29cf71

chore: fix styles typo

1dfcead

Merge branch 'main' into 1536-component-dialog

e701651

refactor: split dialog up into variants

b19cd2f

gfellerph linked an issue Apr 15, 2024 that may be closed by this pull request

Component: Dialog #1536

Closed

gfellerph added 2 commits May 1, 2024 08:13

Merge branch 'main' into 1536-component-dialog

f1cca20

Merge branch 'main' into 1536-component-dialog

bc6c902

fix: animations

49b3875

gfellerph added the v9 label Jul 22, 2024

gfellerph and others added 8 commits July 23, 2024 10:00

Merge branch 'main' into 1536-component-dialog

534d53e

Merge branch 'main' into 1536-component-dialog

ca07cd6

chore: clean up and scope down to just dialog

beed725

chore: deprecate notification without replacement

f023e4f

There will be a new notification concept for Design v2

fix: linting

fd8c570

fix: disable this behavior, does not work with non-modal dialogs

dac7bb5

chore: add snapshot tests

e305176

fix: linting errors

5da958c

gfellerph marked this pull request as ready for review August 9, 2024 13:27

gfellerph requested a review from a team as a code owner August 9, 2024 13:27

gfellerph requested a review from alizedebray August 9, 2024 13:27

gfellerph added v8 and removed v9 labels Aug 9, 2024

Merge branch 'main' into 1536-component-dialog

1d85c6e

alizedebray requested changes Aug 22, 2024

View reviewed changes

gfellerph and others added 5 commits September 10, 2024 07:04

Update .changeset/popular-games-rush.md

881cae5

Co-authored-by: Alizé Debray <[email protected]>

Update packages/documentation/package.json

cadcfcb

Co-authored-by: Alizé Debray <[email protected]>

Update packages/documentation/src/stories/components/dialog/dialog.do…

3e18775

…cs.mdx Co-authored-by: Alizé Debray <[email protected]>

Update packages/documentation/src/stories/components/dialog/dialog.do…

86a987c

…cs.mdx Co-authored-by: Alizé Debray <[email protected]>

Merge branch 'main' into 1536-component-dialog

f91aef5

gfellerph removed the v8 label Sep 10, 2024

gfellerph and others added 3 commits September 10, 2024 08:33

Apply suggestions from code review

159a291

Co-authored-by: Alizé Debray <[email protected]>

Merge branch '1536-component-dialog' of https://github.com/swisspost/…

5017cf8

…design-system into 1536-component-dialog

update docs and styles to use classes instead of custom elements

55b3f02

gfellerph requested a review from alizedebray September 10, 2024 08:00

removed angular form data example

8f38ff7

alizedebray approved these changes Sep 12, 2024

View reviewed changes

gfellerph added 2 commits October 7, 2024 11:56

Merge branch 'main' into 1536-component-dialog

e163bfa

chore: fix dialog display

df30dca

gfellerph mentioned this pull request Oct 8, 2024

Component: Dialog #1536

Closed

revert margins for the dialog

3021bb0

gfellerph merged commit da7b10f into main Oct 8, 2024
11 checks passed

gfellerph deleted the 1536-component-dialog branch October 8, 2024 18:31

swisspost-bot mentioned this pull request Oct 8, 2024

chore(changesets): 🦋📦 publish packages (main) (next) #3685

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(dialog): adding styles for native dialog #2772

feat(dialog): adding styles for native dialog #2772

gfellerph commented Mar 7, 2024 •

edited

Loading

changeset-bot bot commented Mar 7, 2024 •

edited

Loading

swisspost-bot commented Mar 7, 2024 •

edited

Loading

gfellerph Mar 7, 2024

swisspost-bot commented May 29, 2024 •

edited

Loading

sonarcloud bot commented May 29, 2024

alizedebray commented Aug 13, 2024

gfellerph commented Aug 13, 2024

socket-security bot commented Aug 15, 2024 •

edited

Loading

alizedebray left a comment •

edited

Loading

alizedebray left a comment

sonarcloud bot commented Oct 8, 2024

feat(dialog): adding styles for native dialog #2772

feat(dialog): adding styles for native dialog #2772

Conversation

gfellerph commented Mar 7, 2024 • edited Loading

changeset-bot bot commented Mar 7, 2024 • edited Loading

🦋 Changeset detected

swisspost-bot commented Mar 7, 2024 • edited Loading

gfellerph Mar 7, 2024

Choose a reason for hiding this comment

swisspost-bot commented May 29, 2024 • edited Loading

sonarcloud bot commented May 29, 2024

Quality Gate failed

alizedebray commented Aug 13, 2024

gfellerph commented Aug 13, 2024

socket-security bot commented Aug 15, 2024 • edited Loading

alizedebray left a comment • edited Loading

Choose a reason for hiding this comment

alizedebray left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Oct 8, 2024

Quality Gate passed

gfellerph commented Mar 7, 2024 •

edited

Loading

changeset-bot bot commented Mar 7, 2024 •

edited

Loading

swisspost-bot commented Mar 7, 2024 •

edited

Loading

swisspost-bot commented May 29, 2024 •

edited

Loading

socket-security bot commented Aug 15, 2024 •

edited

Loading

alizedebray left a comment •

edited

Loading