-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(documentation): Reorganized Accessibility folder and added Form Grouping Controls Section #3638
base: main
Are you sure you want to change the base?
Conversation
…rouping Controls Section
🦋 Changeset detectedLatest commit: 2fc639b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Related Previews |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected], npm/[email protected] |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
… section with minor text changes and corrected the div example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
### Disabled state | ||
## Disabled state | ||
|
||
Disabled states of input fields or buttons pose many accessibility issues. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also fix the wrong implementation of ul
/ li
elements?
A div
is semantically wrong here and not allowed as a child in an ul
element.
Should be implemented somehow like this:
<ul class="list-unstyled">
<li class="d-flex gap-mini">
<div>❌</div><div>List Item text</div>
</li>
</ul>
Do this for all ul
/ li
constructs on the page, which are using ❌ or ✔️ as marker/icon.
<div role="group" aria-labelledby="group-label "aria-describedby="group-description"> | ||
<span id="group-label" style="margin-right:5px">Gender </span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These elements are not rendered on the page under the preview URL. Not sure why, do you have any idea?
|
||
<figure> | ||
<blockquote class="blockquote" lang="de"> | ||
<p>Die Postdienste müssen so angeboten werden, dass Menschen mit Behinderungen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we translate this to english? For example with the post translater or with deepl or some other online service.
Bedingungen wie Menschen ohne Behinderungen beanspruchen können.</p> | ||
</blockquote> | ||
<figcaption class="blockquote-footer"> | ||
<cite>§14.7 <a href="https://www.fedlex.admin.ch/eli/cc/2012/585/de#art_14">Swiss postal law</a></cite> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the language can be choosen by the page itself, depending on the browser language.
<cite>§14.7 <a href="https://www.fedlex.admin.ch/eli/cc/2012/585/de#art_14">Swiss postal law</a></cite> | |
<cite>§14.7 <a href="https://www.fedlex.admin.ch/eli/cc/2012/585">Swiss postal law</a></cite> |
No description provided.