Merge pull request #595 from hiddenalpha/RespondFailureImmediatelyInP…

…laceOfWaitingForTimeoutDueToIllegalStateException-20240617 [SDCISA-16207] Respond failure immediately in place of waiting for timeout
swisspost · Jun 17, 2024 · 5e0b379 · 5e0b379
2 parents 4d4f62a + b32ac56
commit 5e0b379
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/gateleen-routing/src/main/java/org/swisspush/gateleen/routing/Forwarder.java b/gateleen-routing/src/main/java/org/swisspush/gateleen/routing/Forwarder.java
@@ -503,7 +503,7 @@ private Handler<AsyncResult<HttpClientResponse>> getAsyncHttpClientResponseHandl
 
             final LoggingWriteStream loggingWriteStream = new LoggingWriteStream(req.response(), loggingHandler, false);
             final Pump pump = Pump.pump(cRes, loggingWriteStream);
-            cRes.endHandler(v -> {
+            Handler<Void> cResEndHandler = v -> {
                 try {
                     req.response().end();
 
@@ -516,7 +516,14 @@ private Handler<AsyncResult<HttpClientResponse>> getAsyncHttpClientResponseHandl
                     // ignore because maybe already closed
                 }
                 vertx.runOnContext(event -> loggingHandler.log());
-            });
+            };
+            try {
+                cRes.endHandler(cResEndHandler);
+            } catch (IllegalStateException ex) {
+                log.warn("cRes.endHandler() failed", ex);
+                respondError(req, StatusCode.INTERNAL_SERVER_ERROR);
+                return;
+            }
             pump.start();
 
             Runnable unpump = () -> {