Cleanup random findings #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hiddenalpha
commented
Jun 28, 2023
hiddenalpha
commented
- Add some error handling.
- Reduce amount of string comparisons where a simple int compare is sufficient.
- Remove redundant text from some log messages.
- Don't call toString() twice but re-use value.
- Add error handling. - Prevent millions of nonsense string comparions where a simple int compare is enough. - Shorten useless complicated messages. Cache result of toString(). - Replace ugly imports. References (www): - https://m.youtube.com/watch?v=x2EOOJg8FkA - https://m.youtube.com/watch?v=EpYr3T5VP6w - https://medium.com/swlh/yagni-and-dry-the-kiss-of-death-for-your-software-project-cfd44b0654b6#fc82 References (I'm not allowed to make those publicly available): - https://wikit.post.ch/x/_Bv6Rw - https://wikit.post.ch/x/iRepPQ - https://jira.post.ch/browse/SDCISA-10871 (wip @ 284d263)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #519 +/- ##
=============================================
- Coverage 47.41% 47.29% -0.12%
+ Complexity 1781 1772 -9
=============================================
Files 224 224
Lines 11672 11684 +12
Branches 1225 1227 +2
=============================================
- Hits 5534 5526 -8
- Misses 5646 5672 +26
+ Partials 492 486 -6
☔ View full report in Codecov by Sentry. |
hiddenalpha
force-pushed
the
RandomImprovements-20230628
branch
6 times, most recently
from
bb43b42
to
93e51e0
Compare
hiddenalpha
force-pushed
the
RandomImprovements-20230628
branch
from
8fa36ee
to
d036b62
Compare
ljucam
approved these changes
Jul 27, 2023
Conflicts: gateleen-core/src/main/java/org/swisspush/gateleen/core/http/AbstractHttpClient.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.