Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement another HttpClient method #521

Conversation

hiddenalpha
Copy link
Member

Relates to: SDCISA-12877.

@hiddenalpha hiddenalpha added enhancement java Pull requests that update Java code labels Jul 27, 2023
@hiddenalpha hiddenalpha requested a review from ljucam July 27, 2023 12:18
@hiddenalpha
Copy link
Member Author

hiddenalpha commented Jul 27, 2023

Hi :) Anybody there that could explain to me why my change makes the build fail?

Edit: Any idea? @mcweba , @dominik-cnx

@ljucam
Copy link
Collaborator

ljucam commented Jul 27, 2023

Hi :) Anybody there that could explain to me why my change makes the build fail?

Yeah, problems during build:

Error: The process '/home/runner/work/_actions/nanasess/setup-chromedriver/v1.1.0/lib/setup-chromedriver.sh' failed with exit code 22

@ljucam ljucam closed this Jul 27, 2023
@ljucam ljucam reopened this Jul 27, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (9cb9021) 47.25% compared to head (2f1e88e) 47.34%.
Report is 38 commits behind head on develop.

❗ Current head 2f1e88e differs from pull request most recent head 0870603. Consider uploading reports for the commit 0870603 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #521      +/-   ##
=============================================
+ Coverage      47.25%   47.34%   +0.08%     
- Complexity      1776     1779       +3     
=============================================
  Files            224      224              
  Lines          11659    11672      +13     
  Branches        1225     1225              
=============================================
+ Hits            5510     5526      +16     
+ Misses          5662     5656       -6     
- Partials         487      490       +3     
Files Coverage Δ
.../swisspush/gateleen/core/http/LocalHttpClient.java 0.00% <0.00%> (ø)
...isspush/gateleen/core/http/AbstractHttpClient.java 0.00% <0.00%> (ø)
...org/swisspush/gateleen/logging/LoggingHandler.java 20.11% <0.00%> (-1.27%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hiddenalpha hiddenalpha merged commit 16c28a5 into swisspost:develop Oct 4, 2023
2 of 3 checks passed
@hiddenalpha hiddenalpha deleted the SDCISA-12877-ImplAnotherHttpClientMethod branch October 4, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants