PR for release #531
Merged
PR for release #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add error handling. - Prevent millions of nonsense string comparions where a simple int compare is enough. - Shorten useless complicated messages. Cache result of toString(). - Replace ugly imports. References (www): - https://m.youtube.com/watch?v=x2EOOJg8FkA - https://m.youtube.com/watch?v=EpYr3T5VP6w - https://medium.com/swlh/yagni-and-dry-the-kiss-of-death-for-your-software-project-cfd44b0654b6#fc82 References (I'm not allowed to make those publicly available): - https://wikit.post.ch/x/_Bv6Rw - https://wikit.post.ch/x/iRepPQ - https://jira.post.ch/browse/SDCISA-10871 (wip @ 284d263)
… as requested in review
… how to trigger another build.
…ClientMethod Implement another HttpClient method
Conflicts: gateleen-core/src/main/java/org/swisspush/gateleen/core/http/AbstractHttpClient.java
Cleanup random findings
#529 EventBusAppender instance pollution in Java Heap Space
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #531 +/- ##
============================================
+ Coverage 47.24% 47.70% +0.45%
- Complexity 1777 1784 +7
============================================
Files 224 225 +1
Lines 11669 11704 +35
Branches 1225 1227 +2
============================================
+ Hits 5513 5583 +70
+ Misses 5668 5634 -34
+ Partials 488 487 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.