Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDCISA-13736, SDCISA-10974] Refine logging in BufferBridge, LocalHttpClientRequest, LocalHttpConnection and RequestLogger #544

Conversation

hiddenalpha
Copy link
Member

No description provided.

…pClientRequest, LocalHttpConnection and RequestLogger.
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (0817082) 47.65% compared to head (cfa2ffb) 47.62%.

Files Patch % Lines
...org/swisspush/gateleen/core/http/BufferBridge.java 0.00% 3 Missing ⚠️
...sspush/gateleen/core/http/LocalHttpConnection.java 0.00% 3 Missing ⚠️
...ush/gateleen/core/http/LocalHttpClientRequest.java 0.00% 2 Missing ⚠️
...swisspush/gateleen/core/logging/RequestLogger.java 33.33% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #544      +/-   ##
=============================================
- Coverage      47.65%   47.62%   -0.03%     
  Complexity      1785     1785              
=============================================
  Files            225      225              
  Lines          11727    11734       +7     
  Branches        1226     1226              
=============================================
  Hits            5588     5588              
- Misses          5651     5658       +7     
  Partials         488      488              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hiddenalpha hiddenalpha marked this pull request as ready for review January 5, 2024 15:30
@hiddenalpha hiddenalpha merged commit 51b5486 into swisspost:develop Jan 9, 2024
2 of 6 checks passed
@hiddenalpha hiddenalpha deleted the SDCISA-13736-ApplyFindings-20240105-1340 branch January 9, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants