Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce risk of Logging Resource exhaustion #577

Merged
merged 7 commits into from
May 24, 2024
Merged

Reduce risk of Logging Resource exhaustion #577

merged 7 commits into from
May 24, 2024

Conversation

hiddenalpha
Copy link
Member

No description provided.

@hiddenalpha hiddenalpha added the java Pull requests that update Java code label May 21, 2024
hiddenalpha added a commit to hiddenalpha/vertx-rest-storage that referenced this pull request May 21, 2024
@hiddenalpha
Skip instance creation if possible.
d825c58 
Related: SDCISA-15833, swisspost/vertx-redisques#170, swisspost/vertx-redisques#177, swisspost#186, swisspost/gateleen#577
hiddenalpha added a commit to hiddenalpha/vertx-redisques that referenced this pull request May 21, 2024
@hiddenalpha
Extract ExceptionFactory in its own branch
88c44d4 
Related: SDCISA-15833, swisspost#170, swisspost#177, swisspost/vertx-rest-storage#186, swisspost/gateleen#577
hiddenalpha added a commit to hiddenalpha/vertx-redisques that referenced this pull request May 21, 2024
@hiddenalpha
Move log to where it should be.
1003147 
Related: SDCISA-15833, swisspost#170, swisspost#177, swisspost/vertx-rest-storage#186, swisspost/gateleen#577
hiddenalpha added a commit to hiddenalpha/vertx-redisques that referenced this pull request May 21, 2024
@hiddenalpha
Drop now unused methods
f0152df 
Related: SDCISA-15833, swisspost#170, swisspost#177, swisspost/vertx-rest-storage#186, swisspost/gateleen#577
mcweba
mcweba requested changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@mcweba mcweba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes all look good. Before merging this to develop I would suggest to replace all occurrences of logging new Exception(...) with the new factory method

hiddenalpha added a commit to hiddenalpha/vertx-rest-storage that referenced this pull request May 23, 2024
@hiddenalpha
Fix parts for 'swisspost#186 (review)'
701dce2 
Related: SDCISA-15833, swisspost/vertx-redisques#170, swisspost/vertx-redisques#177, swisspost#186, swisspost/gateleen#577
hiddenalpha added a commit to hiddenalpha/vertx-rest-storage that referenced this pull request May 23, 2024
@hiddenalpha
Fix more for 'swisspost#186 (review)'
25cdec3 
Related: SDCISA-15833, swisspost/vertx-redisques#170, swisspost/vertx-redisques#177, swisspost#186, swisspost/gateleen#577
@hiddenalpha hiddenalpha requested a review from mcweba May 24, 2024 07:23
hiddenalpha added a commit to hiddenalpha/vertx-redisques that referenced this pull request May 24, 2024
@hiddenalpha
Merge splitt-off changes back to feature from develop
0d93d87 
OMG! What a conflict mess.

Conflicts:
      src/main/java/org/swisspush/redisques/QueueStatsService.java
      src/main/java/org/swisspush/redisques/RedisQues.java
      src/main/java/org/swisspush/redisques/action/GetQueuesItemsCountAction.java
      src/main/java/org/swisspush/redisques/handler/GetQueuesItemsCountHandler.java
      src/main/java/org/swisspush/redisques/handler/RedisquesHttpRequestHandler.java
      src/main/java/org/swisspush/redisques/util/QueueActionFactory.java
      src/main/java/org/swisspush/redisques/util/QueueStatisticsCollector.java

Related: SDCISA-15833, swisspost#170, swisspost#177, swisspost/vertx-rest-storage#186, swisspost/gateleen#577
hiddenalpha added a commit to hiddenalpha/vertx-redisques that referenced this pull request May 24, 2024
@hiddenalpha
[SDCISA-15833, swisspost#170] Cleanup
cda08f9 
Related: swisspost#177, swisspost/vertx-rest-storage#186, swisspost/gateleen#577
@hiddenalpha
Replace NPE by warn log.
02a059a 
Related: SDCISA-15833, swisspost/vertx-redisques#170, swisspost/vertx-redisques#177, swisspost/vertx-rest-storage#186, swisspost#577
@hiddenalpha
Merge upstream changes from develop to feature
cc94fb3 
Reason for the conflict is here:
swisspost#577 (review)

Conflicts:
      gateleen-delegate/src/test/java/org/swisspush/gateleen/delegate/DelegateTest.java
hiddenalpha added a commit to hiddenalpha/vertx-redisques that referenced this pull request May 24, 2024
@hiddenalpha
[SDCISA-15833, swisspost#170] Fix some todos.
53a830c 
Related: swisspost#177, swisspost/vertx-rest-storage#186, swisspost/gateleen#577
@hiddenalpha hiddenalpha merged commit 2c8c606 into swisspost:develop May 24, 2024
1 check passed
@hiddenalpha hiddenalpha deleted the ReduceLogExhaustionIssues-20240521 branch May 24, 2024 16:04
hiddenalpha added a commit to hiddenalpha/gateleen that referenced this pull request May 27, 2024
@hiddenalpha
Errors should be reported ONCE only.
aaab9d8 
Related: SDCISA-15833, swisspost/vertx-redisques#170, swisspost/vertx-redisques#177, swisspost/vertx-rest-storage#186, swisspost#577, swisspost/vertx-redisques#181
hiddenalpha added a commit to hiddenalpha/vertx-redisques that referenced this pull request May 28, 2024
@hiddenalpha
Use quota to limit parallelity to publish queue statistics.
b1faef1 
Related: SDCISA-15833, swisspost#170, swisspost#177, swisspost/vertx-rest-storage#186, swisspost/gateleen#577, swisspost#181, swisspost/gateleen#493, swisspost/vertx-rest-storage#188
hiddenalpha added a commit to hiddenalpha/vertx-redisques that referenced this pull request May 28, 2024
@hiddenalpha
Merge upstream changes from develop to feature
d6d3d0a 
Related: SDCISA-15833, swisspost#170, swisspost#177, swisspost/vertx-rest-storage#186, swisspost/gateleen#577, swisspost#181, swisspost/gateleen#493, swisspost/vertx-rest-storage#188
hiddenalpha added a commit to hiddenalpha/gateleen that referenced this pull request May 30, 2024
@hiddenalpha
Make use of ExceptionFactory
46016a2 
Related: SDCISA-15833, swisspost/vertx-redisques#170, swisspost/vertx-redisques#177, swisspost/vertx-rest-storage#186, swisspost#577, swisspost/vertx-redisques#181, swisspost#493, swisspost/vertx-rest-storage#188
hiddenalpha added a commit to hiddenalpha/gateleen that referenced this pull request May 30, 2024
@hiddenalpha
Fix test
0e72125 
Related: SDCISA-15833, swisspost/vertx-redisques#170, swisspost/vertx-redisques#177, swisspost/vertx-rest-storage#186, swisspost#577, swisspost/vertx-redisques#181, swisspost#493, swisspost/vertx-rest-storage#188
hiddenalpha added a commit to hiddenalpha/gateleen that referenced this pull request Jun 4, 2024
@hiddenalpha
Merge upstream changes from develop to feature
acbcdac 
Related: SDCISA-15633, SDCISA-15833, SDCISA-16147, swisspost/vertx-redisques#170, swisspost/vertx-redisques#177, swisspost/vertx-rest-storage#186, swisspost#577, swisspost/vertx-redisques#181, swisspost#493, swisspost/vertx-rest-storage#188, swisspost#583
hiddenalpha added a commit to hiddenalpha/gateleen that referenced this pull request Jun 4, 2024
@hiddenalpha
[SDCISA-16147, swisspost#583] Quick-n-dirty just waste anothers threa…
ae29409 
…ds time for JSON serialization.

Related: SDCISA-15633, SDCISA-15833, SDCISA-16147, swisspost/vertx-redisques#170, swisspost/vertx-redisques#177, swisspost/vertx-rest-storage#186, swisspost#577, swisspost/vertx-redisques#181, swisspost#493, swisspost/vertx-rest-storage#188, swisspost#583
hiddenalpha added a commit to hiddenalpha/gateleen that referenced this pull request Jun 4, 2024
@hiddenalpha
[SDCISA-16147, swisspost#583] Some cleanup
721a69a 
Related: SDCISA-15633, SDCISA-15833, SDCISA-16147, swisspost/vertx-redisques#170, swisspost/vertx-redisques#177, swisspost/vertx-rest-storage#186, swisspost#577, swisspost/vertx-redisques#181, swisspost#493, swisspost/vertx-rest-storage#188, swisspost#583
hiddenalpha added a commit to hiddenalpha/gateleen that referenced this pull request Jun 4, 2024
@hiddenalpha
[SDCISA-16147, swisspost#583] Fix the fix.
2bc60b9 
Related: SDCISA-15633, SDCISA-15833, SDCISA-16147, swisspost/vertx-redisques#170, swisspost/vertx-redisques#177, swisspost/vertx-rest-storage#186, swisspost#577, swisspost/vertx-redisques#181, swisspost#493, swisspost/vertx-rest-storage#188, swisspost#583
hiddenalpha added a commit to hiddenalpha/gateleen that referenced this pull request Jun 4, 2024
@hiddenalpha
[SDCISA-16147, swisspost#583] Quick-n-dirty just waste anothers threa…
0d79387 
…ds time for JSON serialization.

Related: SDCISA-15633, SDCISA-15833, SDCISA-16147, swisspost/vertx-redisques#170, swisspost/vertx-redisques#177, swisspost/vertx-rest-storage#186, swisspost#577, swisspost/vertx-redisques#181, swisspost#493, swisspost/vertx-rest-storage#188, swisspost#583
hiddenalpha added a commit to hiddenalpha/gateleen that referenced this pull request Jun 4, 2024
@hiddenalpha
[SDCISA-16147, swisspost#583] Quick-n-dirty just waste anothers threa…
0037164 
…ds time for JSON serialization.

Update:
- Fix hard-to-trace vertxPromise NPE.

Related: SDCISA-15633, SDCISA-15833, SDCISA-16147, swisspost/vertx-redisques#170, swisspost/vertx-redisques#177, swisspost/vertx-rest-storage#186, swisspost#577, swisspost/vertx-redisques#181, swisspost#493, swisspost/vertx-rest-storage#188, swisspost#583
hiddenalpha added a commit to hiddenalpha/gateleen that referenced this pull request Jun 6, 2024
@hiddenalpha
[SDCISA-16147, swisspost#583] Allow threading bugs to slip through.
5bda148 
Related: SDCISA-15633, SDCISA-15833, SDCISA-16147, swisspost/vertx-redisques#170, swisspost/vertx-redisques#177, swisspost/vertx-rest-storage#186, swisspost#577, swisspost/vertx-redisques#181, swisspost#493, swisspost/vertx-rest-storage#188, swisspost#583
hiddenalpha added a commit to hiddenalpha/gateleen that referenced this pull request Jun 6, 2024
@hiddenalpha
[SDCISA-16147, swisspost#583] Allow threading bugs to slip through as…
c36b202 
… requested (swisspost#584 (comment))

Related: SDCISA-15633, SDCISA-15833, SDCISA-16147, swisspost/vertx-redisques#170, swisspost/vertx-redisques#177, swisspost/vertx-rest-storage#186, swisspost#577, swisspost/vertx-redisques#181, swisspost#493, swisspost/vertx-rest-storage#188, swisspost#583
hiddenalpha added a commit to hiddenalpha/gateleen that referenced this pull request Jun 7, 2024
@hiddenalpha
[SDCISA-16147, swisspost#583] Fix another make-json-EventLoop-blocker
400f70f 
Related: SDCISA-15633, SDCISA-15833, SDCISA-16147, swisspost/vertx-redisques#170, swisspost/vertx-redisques#177, swisspost/vertx-rest-storage#186, swisspost#577, swisspost/vertx-redisques#181, swisspost#493, swisspost/vertx-rest-storage#188, swisspost#583, swisspost#584
hiddenalpha added a commit to hiddenalpha/gateleen that referenced this pull request Jun 7, 2024
@hiddenalpha
[SDCISA-16147, swisspost#583] Adjust measurement.
e2f576b 
Related: SDCISA-15633, SDCISA-15833, SDCISA-16147, swisspost/vertx-redisques#170, swisspost/vertx-redisques#177, swisspost/vertx-rest-storage#186, swisspost#577, swisspost/vertx-redisques#181, swisspost#493, swisspost/vertx-rest-storage#188, swisspost#583, swisspost#584
hiddenalpha added a commit to hiddenalpha/gateleen that referenced this pull request Jun 17, 2024
@hiddenalpha
[SDCISA-16207] Respond failure immediately in place of waiting for a …
b32ac56 
…timeout.

Related: SDCISA-15633, SDCISA-15833, SDCISA-16147, SDCISA-16293, SDCISA-16207, SDCISA-16197, SDCISA-16194, SDCISA-16204,swisspost/vertx-redisques#170, swisspost/vertx-redisques#177, swisspost/vertx-rest-storage#186, swisspost#577, swisspost/vertx-redisques#181, swisspost#493, swisspost/vertx-rest-storage#188, swisspost#583, swisspost#584, swisspost/vertx-redisques#186, swisspost#593
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcweba mcweba mcweba approved these changes

@Kusig Kusig Awaiting requested review from Kusig

@ljucam ljucam Awaiting requested review from ljucam

@linovifian linovifian Awaiting requested review from linovifian

Assignees
No one assigned
Labels
java Pull requests that update Java code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiddenalpha @mcweba