Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge to master to trigger release #610

Merged
merged 21 commits into from
Sep 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gateleen-cache/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.swisspush.gateleen</groupId>
<artifactId>gateleen</artifactId>
<version>2.1.10-SNAPSHOT</version>
<version>2.1.11-SNAPSHOT</version>
</parent>

<artifactId>gateleen-cache</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion gateleen-core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.swisspush.gateleen</groupId>
<artifactId>gateleen</artifactId>
<version>2.1.10-SNAPSHOT</version>
<version>2.1.11-SNAPSHOT</version>
</parent>

<artifactId>gateleen-core</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion gateleen-delegate/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.swisspush.gateleen</groupId>
<artifactId>gateleen</artifactId>
<version>2.1.10-SNAPSHOT</version>
<version>2.1.11-SNAPSHOT</version>
</parent>

<artifactId>gateleen-delegate</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion gateleen-delta/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.swisspush.gateleen</groupId>
<artifactId>gateleen</artifactId>
<version>2.1.10-SNAPSHOT</version>
<version>2.1.11-SNAPSHOT</version>
</parent>

<artifactId>gateleen-delta</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion gateleen-expansion/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.swisspush.gateleen</groupId>
<artifactId>gateleen</artifactId>
<version>2.1.10-SNAPSHOT</version>
<version>2.1.11-SNAPSHOT</version>
</parent>

<artifactId>gateleen-expansion</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion gateleen-hook-js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"grunt-ngdocs": "0.2.10",
"jasmine-core": "2.5.0",
"jshint": "2.9.3",
"karma": "1.2.0",
"karma": "6.3.9",
"karma-chrome-launcher": "2.2.0",
"karma-coverage": "1.1.1",
"karma-html-reporter": "0.2.7",
Expand Down
4 changes: 2 additions & 2 deletions gateleen-hook-js/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>org.swisspush.gateleen</groupId>
<artifactId>gateleen</artifactId>
<version>2.1.10-SNAPSHOT</version>
<version>2.1.11-SNAPSHOT</version>
</parent>
<artifactId>gateleen-hook-js</artifactId>
<packaging>jar</packaging>
Expand Down Expand Up @@ -81,7 +81,7 @@
<!-- we need node in phase generate-resources, so do this before-->
<phase>initialize</phase>
<configuration>
<nodeVersion>v8.9.4</nodeVersion>
<nodeVersion>v16.9.1</nodeVersion>
<npmVersion>6.14.8</npmVersion>
<nodeDownloadRoot>${nodeDownloadRoot}</nodeDownloadRoot>
<npmDownloadRoot>${npmDownloadRoot}</npmDownloadRoot>
Expand Down
2 changes: 1 addition & 1 deletion gateleen-hook/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.swisspush.gateleen</groupId>
<artifactId>gateleen</artifactId>
<version>2.1.10-SNAPSHOT</version>
<version>2.1.11-SNAPSHOT</version>
</parent>

<artifactId>gateleen-hook</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion gateleen-kafka/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.swisspush.gateleen</groupId>
<artifactId>gateleen</artifactId>
<version>2.1.10-SNAPSHOT</version>
<version>2.1.11-SNAPSHOT</version>
</parent>

<artifactId>gateleen-kafka</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion gateleen-logging/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.swisspush.gateleen</groupId>
<artifactId>gateleen</artifactId>
<version>2.1.10-SNAPSHOT</version>
<version>2.1.11-SNAPSHOT</version>
</parent>

<artifactId>gateleen-logging</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion gateleen-merge/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.swisspush.gateleen</groupId>
<artifactId>gateleen</artifactId>
<version>2.1.10-SNAPSHOT</version>
<version>2.1.11-SNAPSHOT</version>
</parent>

<artifactId>gateleen-merge</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion gateleen-monitoring/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.swisspush.gateleen</groupId>
<artifactId>gateleen</artifactId>
<version>2.1.10-SNAPSHOT</version>
<version>2.1.11-SNAPSHOT</version>
</parent>

<artifactId>gateleen-monitoring</artifactId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@
if (metricName != null) {
double duration = (System.nanoTime() - startTime) / 1000000d;
vertx.eventBus().publish(getMonitoringAddress(),
new JsonObject().put(METRIC_NAME, prefix + "routing." + metricName + ".duration").put(METRIC_ACTION, "update").put("n", duration));
new JsonObject().put(METRIC_NAME, prefix + "routing." + metricName + ".duration").put(METRIC_ACTION, "set").put("n", duration));

Check warning on line 356 in gateleen-monitoring/src/main/java/org/swisspush/gateleen/monitoring/MonitoringHandler.java

View check run for this annotation

Codecov / codecov/patch

gateleen-monitoring/src/main/java/org/swisspush/gateleen/monitoring/MonitoringHandler.java#L356

Added line #L356 was not covered by tests
}
updatePendingRequestCount(false);
}
Expand Down Expand Up @@ -389,7 +389,7 @@
vertx.eventBus().request(getRedisquesAddress(), buildGetQueueItemsCountOperation(queue), (Handler<AsyncResult<Message<JsonObject>>>) reply -> {
if (reply.succeeded() && OK.equals(reply.result().body().getString(STATUS))) {
final long count = reply.result().body().getLong(VALUE);
vertx.eventBus().publish(getMonitoringAddress(), new JsonObject().put(METRIC_NAME, prefix + LAST_USED_QUEUE_SIZE_METRIC).put(METRIC_ACTION, "update").put("n", count));
vertx.eventBus().publish(getMonitoringAddress(), new JsonObject().put(METRIC_NAME, prefix + LAST_USED_QUEUE_SIZE_METRIC).put(METRIC_ACTION, "set").put("n", count));

Check warning on line 392 in gateleen-monitoring/src/main/java/org/swisspush/gateleen/monitoring/MonitoringHandler.java

View check run for this annotation

Codecov / codecov/patch

gateleen-monitoring/src/main/java/org/swisspush/gateleen/monitoring/MonitoringHandler.java#L392

Added line #L392 was not covered by tests
} else {
log.error("Error gathering queue size for queue '{}'", queue);
}
Expand Down
2 changes: 1 addition & 1 deletion gateleen-packing/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.swisspush.gateleen</groupId>
<artifactId>gateleen</artifactId>
<version>2.1.10-SNAPSHOT</version>
<version>2.1.11-SNAPSHOT</version>
</parent>

<artifactId>gateleen-packing</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion gateleen-player/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.swisspush.gateleen</groupId>
<artifactId>gateleen</artifactId>
<version>2.1.10-SNAPSHOT</version>
<version>2.1.11-SNAPSHOT</version>
</parent>

<artifactId>gateleen-player</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion gateleen-playground/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.swisspush.gateleen</groupId>
<artifactId>gateleen</artifactId>
<version>2.1.10-SNAPSHOT</version>
<version>2.1.11-SNAPSHOT</version>
</parent>

<artifactId>gateleen-playground</artifactId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,11 @@
"description": "CircuitBreaker API",
"url": "http://localhost:7013/playground/server/queuecircuitbreaker/circuit/$1"
},
"/playground/server/queuing/(.*)": {
"description": "Redisques API",
"metricName": "server-queuing-api",
"url": "http://localhost:7015/queuing/$1"
},
"/playground/server/redisques/(.*)": {
"description": "Redisques API",
"url": "http://localhost:7015/queuing/$1"
Expand Down
2 changes: 1 addition & 1 deletion gateleen-qos/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.swisspush.gateleen</groupId>
<artifactId>gateleen</artifactId>
<version>2.1.10-SNAPSHOT</version>
<version>2.1.11-SNAPSHOT</version>
</parent>

<artifactId>gateleen-qos</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion gateleen-queue/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.swisspush.gateleen</groupId>
<artifactId>gateleen</artifactId>
<version>2.1.10-SNAPSHOT</version>
<version>2.1.11-SNAPSHOT</version>
</parent>

<artifactId>gateleen-queue</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion gateleen-routing/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.swisspush.gateleen</groupId>
<artifactId>gateleen</artifactId>
<version>2.1.10-SNAPSHOT</version>
<version>2.1.11-SNAPSHOT</version>
</parent>

<artifactId>gateleen-routing</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion gateleen-runconfig/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.swisspush.gateleen</groupId>
<artifactId>gateleen</artifactId>
<version>2.1.10-SNAPSHOT</version>
<version>2.1.11-SNAPSHOT</version>
</parent>

<artifactId>gateleen-runconfig</artifactId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,7 @@ public static JsonObject buildRedisquesConfig() {
.address(Address.redisquesAddress())
.processorAddress(Address.queueProcessorAddress())
.httpRequestHandlerEnabled(true)
.enableQueueNameDecoding(false)
.httpRequestHandlerPort(7015)
.redisReconnectAttempts(-1)
.redisPoolRecycleTimeoutMs(-1)
Expand Down
2 changes: 1 addition & 1 deletion gateleen-scheduler/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.swisspush.gateleen</groupId>
<artifactId>gateleen</artifactId>
<version>2.1.10-SNAPSHOT</version>
<version>2.1.11-SNAPSHOT</version>
</parent>

<artifactId>gateleen-scheduler</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion gateleen-security/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.swisspush.gateleen</groupId>
<artifactId>gateleen</artifactId>
<version>2.1.10-SNAPSHOT</version>
<version>2.1.11-SNAPSHOT</version>
</parent>

<artifactId>gateleen-security</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion gateleen-test/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.swisspush.gateleen</groupId>
<artifactId>gateleen</artifactId>
<version>2.1.10-SNAPSHOT</version>
<version>2.1.11-SNAPSHOT</version>
</parent>
<artifactId>gateleen-test</artifactId>
<packaging>jar</packaging>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@
@RunWith(VertxUnitRunner.class)
public class MonitoringTest extends AbstractTest {
Logger log = LoggerFactory.getLogger(MonitoringTest.class);

private static final long MAX_DURATION_THRESHOLD = 100;
private static final double MEAN_DURATION_THRESHOLD = 25.0;

/**
* Overwrite RestAssured configuration
*/
Expand Down Expand Up @@ -95,17 +91,7 @@ public void testStorageMetrics(TestContext context) throws Exception {

// read the jmx infos
if (mbs.isRegistered(beanNameObject)) {
log.info(" > Min: {}", mbs.getAttribute(beanNameObject, "Min"));
log.info(" > Mean: {}", mbs.getAttribute(beanNameObject, "Mean"));
log.info(" > Max: {}", mbs.getAttribute(beanNameObject, "Max"));
log.info(" > Count: {}", mbs.getAttribute(beanNameObject, "Count"));
log.info(" > StdDev: {}", mbs.getAttribute(beanNameObject, "StdDev"));

// check max threshold
context.assertTrue((Long) mbs.getAttribute(beanNameObject, "Max") <= MAX_DURATION_THRESHOLD, "'Max' should be below the threshold");

// checm mean threshold
context.assertTrue((Double) mbs.getAttribute(beanNameObject, "Mean") <= MEAN_DURATION_THRESHOLD, "'Mean' should be below the threshold");
log.info(" > Value: {}", mbs.getAttribute(beanNameObject, "Value"));
} else {
context.fail("could not found mbean " + beanName);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,18 +78,18 @@ public void testDiscardPayloadQueueingStrategy(TestContext context) {
when().get("pushnotification/queuing/queues/")
.then().assertThat()
.body("queues", hasItem(queueName));
given().urlEncodingEnabled(true).when().get("pushnotification/queuing/queues/" + queueName)
given().urlEncodingEnabled(false).when().get("pushnotification/queuing/queues/" + queueName)
.then().assertThat()
.body(queueName, hasSize(3));

// check that no queue items do have a payload
String responseIndex0 = given().urlEncodingEnabled(true)
String responseIndex0 = given().urlEncodingEnabled(false)
.when().get("pushnotification/queuing/queues/" + queueName + "/0")
.then().extract().response().asString();
String responseIndex1 = given().urlEncodingEnabled(true)
String responseIndex1 = given().urlEncodingEnabled(false)
.when().get("pushnotification/queuing/queues/" + queueName + "/1")
.then().extract().response().asString();
String responseIndex2 = given().urlEncodingEnabled(true)
String responseIndex2 = given().urlEncodingEnabled(false)
.when().get("pushnotification/queuing/queues/" + queueName + "/2")
.then().extract().response().asString();

Expand Down Expand Up @@ -147,7 +147,7 @@ public void testReducedPropagationQueueingStrategy(TestContext context) {
.then().assertThat()
.body("queues", hasItem(queueName))
.body("queues", not(hasItem(managerQueue)));
given().urlEncodingEnabled(true).when().get("pushnotification/queuing/queues/" + queueName)
given().urlEncodingEnabled(false).when().get("pushnotification/queuing/queues/" + queueName)
.then().assertThat()
.body(queueName, hasSize(3));
when().get("pushnotification/queuing/locks/")
Expand All @@ -158,10 +158,10 @@ public void testReducedPropagationQueueingStrategy(TestContext context) {
// after 5s an unlocked manager queue with a single queue item should exist and the original queue should be empty
// and its lock should have been deleted
Awaitility.await().untilAsserted(() -> when().get("pushnotification/queuing/queues/").then().assertThat().body("queues", hasItem(managerQueue)));
given().urlEncodingEnabled(true).when().get("pushnotification/queuing/queues/" + managerQueue)
given().urlEncodingEnabled(false).when().get("pushnotification/queuing/queues/" + managerQueue)
.then().assertThat()
.body(managerQueue, hasSize(1));
given().urlEncodingEnabled(true).when().get("pushnotification/queuing/queues/" + queueName)
given().urlEncodingEnabled(false).when().get("pushnotification/queuing/queues/" + queueName)
.then().assertThat()
.body(queueName, empty());

Expand All @@ -181,7 +181,7 @@ public void testReducedPropagationQueueingStrategy(TestContext context) {
.then().assertThat()
.body("queues", hasItem(queueName))
.body("queues", hasItem(managerQueue));
given().urlEncodingEnabled(true).when().get("pushnotification/queuing/queues/" + queueName)
given().urlEncodingEnabled(false).when().get("pushnotification/queuing/queues/" + queueName)
.then().assertThat()
.body(queueName, hasSize(2));
when().get("pushnotification/queuing/locks/")
Expand All @@ -193,10 +193,10 @@ public void testReducedPropagationQueueingStrategy(TestContext context) {
// and its lock should have been deleted
TestUtils.waitSomeTime(5);
Awaitility.await().untilAsserted(() -> when().get("pushnotification/queuing/queues/").then().assertThat().body("queues", hasItem(managerQueue)));
given().urlEncodingEnabled(true).when().get("pushnotification/queuing/queues/" + managerQueue)
given().urlEncodingEnabled(false).when().get("pushnotification/queuing/queues/" + managerQueue)
.then().assertThat()
.body(managerQueue, hasSize(1));
given().urlEncodingEnabled(true).when().get("pushnotification/queuing/queues/" + queueName)
given().urlEncodingEnabled(false).when().get("pushnotification/queuing/queues/" + queueName)
.then().assertThat()
.body(queueName, empty());

Expand Down
2 changes: 1 addition & 1 deletion gateleen-testhelper/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.swisspush.gateleen</groupId>
<artifactId>gateleen</artifactId>
<version>2.1.10-SNAPSHOT</version>
<version>2.1.11-SNAPSHOT</version>
</parent>

<artifactId>gateleen-testhelper</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion gateleen-user/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.swisspush.gateleen</groupId>
<artifactId>gateleen</artifactId>
<version>2.1.10-SNAPSHOT</version>
<version>2.1.11-SNAPSHOT</version>
</parent>

<artifactId>gateleen-user</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion gateleen-validation/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>org.swisspush.gateleen</groupId>
<artifactId>gateleen</artifactId>
<version>2.1.10-SNAPSHOT</version>
<version>2.1.11-SNAPSHOT</version>
</parent>

<artifactId>gateleen-validation</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

<groupId>org.swisspush.gateleen</groupId>
<artifactId>gateleen</artifactId>
<version>2.1.10-SNAPSHOT</version>
<version>2.1.11-SNAPSHOT</version>
<packaging>pom</packaging>
<name>gateleen</name>
<description>Middleware library based on Vert.x to build advanced JSON/REST communication servers</description>
Expand Down
Loading