native curl socket optimize #5110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5110 +/- ##
==========================================
- Coverage 73.06% 72.98% -0.09%
==========================================
Files 69 69
Lines 14845 14845
==========================================
- Hits 10846 10834 -12
- Misses 3999 4011 +12 see 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
matyhtf
reviewed
Jul 28, 2023
thirdparty/php/curl/interface.cc
Outdated
| @@ -2303,6 +2303,7 @@ PHP_FUNCTION(swoole_native_curl_close) { | |||
| RETURN_FALSE; | |||
| } | |||
|
|
|||
| swoole::curl::destroy_handle(ch->cp); | |||
ext-src/swoole_curl.cc
Outdated
| @@ -35,6 +35,7 @@ Handle *create_handle(CURL *cp) { | |||
| return nullptr; | |||
| } | |||
| Handle *handle = new Handle(cp); | |||
| handle->curl = new Multi(); | |||
There was a problem hiding this comment.
假如这个 handler 是配合 multi 使用的，这里创建的 Multi 无意义
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support native curl persistent connection