Additions to WebSocket closing codes from IANA specification #5204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjavad
changed the title
…specification. Added CLOSE_SERVICE_RESTART, CLOSE_TRY_AGAIN_LATER, CLOSE_BAD_GATEWAY as valid close reasons for the websocket protocol.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5204 +/- ##
==========================================
- Coverage 72.98% 72.96% -0.03%
==========================================
Files 69 69
Lines 14855 14855
==========================================
- Hits 10842 10839 -3
- Misses 4013 4016 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since RFC6455 3 additional closing codes have been added to the specification. Added CLOSE_SERVICE_RESTART, CLOSE_TRY_AGAIN_LATER, CLOSE_BAD_GATEWAY as valid close reasons for the websocket protocol.
The official websocket specification document describes the missing protocol closing codes seen here: https://www.iana.org/assignments/websocket/websocket.txt
Furthermore they are supported by large implementations already square/okhttp#5276.
Further references can be found here https://developer.mozilla.org/en-US/docs/Web/API/CloseEvent/code
The name of CLOSE_BAD_GATEWAY is derrived from both the original longer description and the one commonly used by the mozilla docs.