Synchronize PHP file operation code for different versions #5260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5260 +/- ##
==========================================
+ Coverage 71.54% 71.59% +0.04%
==========================================
Files 105 105
Lines 16084 16084
Branches 2972 2972
==========================================
+ Hits 11508 11516 +8
+ Misses 4522 4513 -9
- Partials 54 55 +1 ☔ View full report in Codecov by Sentry. |
matyhtf
reviewed
Feb 26, 2024
|
|
||
| static php_stream_ops sw_php_stream_stdio_ops = { | ||
| sw_php_stdiop_write, | ||
| sw_php_stdiop_read, | ||
| sw_php_stdiop_close, | ||
| sw_php_stdiop_flush, | ||
| "STDIO/coroutine", |
| #include "thirdparty/php/streams/php_streams_int.h" | ||
|
|
There was a problem hiding this comment.
此处的换行符是有意义的，头文件包含分成了 4 个 section，分别是 标准库、Swoole 头文件、PHP 头文件、第三方头文件。换行区别显示
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.