[5.1] Fix some functions that have been replaced #5480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.1.x #5480 +/- ##
==========================================
+ Coverage 71.56% 71.60% +0.04%
==========================================
Files 105 105
Lines 16094 16094
Branches 2972 2973 +1
==========================================
+ Hits 11517 11524 +7
+ Misses 4523 4515 -8
- Partials 54 55 +1 ☔ View full report in Codecov by Sentry. |
…_string_tolower() functions has been removed, use zend_str_toupper(), zend_string_toupper(), zend_str_tolower(), and zend_string_tolower() respectively instead, Replace zend_atol with zend_ini_parse_quantity.
NathanFreeman
force-pushed
the
function_remove
branch
from
0e2e0ee
to
d6ccdd1
Compare
matyhtf
requested changes
Sep 14, 2024
| --TEST-- | ||
| swoole_server: parse option value to size | ||
| --SKIPIF-- | ||
| <?php require __DIR__ . '/../include/skipif.inc'; ?> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The php_strtoupper(), php_string_toupper(), php_strtolower(), and php_string_tolower() functions has been removed, use zend_str_toupper(), zend_string_toupper(), zend_str_tolower(), and zend_string_tolower() respectively instead