Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dependency on message_serialization #27

Merged
merged 4 commits into from
Nov 17, 2020
Merged

Add dependency on message_serialization #27

merged 4 commits into from
Nov 17, 2020

Conversation

marip8
Copy link
Collaborator

@marip8 marip8 commented Nov 16, 2020

This PR replaces the duplication of the message serialization code with a dependency on the message_serialization package to address #5

@marip8 marip8 requested a review from drchrislewis November 16, 2020 23:45
drchrislewis
drchrislewis approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@drchrislewis drchrislewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work

@drchrislewis drchrislewis merged commit e8aecb6 into swri-robotics:master Nov 17, 2020
@marip8 marip8 deleted the update/message_serialization branch November 17, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drchrislewis drchrislewis drchrislewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marip8 @drchrislewis