fix: stylesheet loading #57
Open
+14
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Special thanks to @Nam-Hai for helping me on this. |
|
Welcome and thanks for contributing. This looks great! Never realized this was broken in the first place. Tests are passing, but I'll give this a try in our playground and report back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix the loading of Stylesheets.
Currently they are cloned before inserted to the current page, but the one that is awaited to be loaded is not the cloned one. So it never loads.
I am fixing this by returning the newly cloned one.
It also fix the infinite loop / memory leak in the
waitForStylesheetfunction that occurs when the provided timeout is elapsed and the stylesheet never loads.Checks
masterbranchnpm run lint)npm run test)