Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "extension" linemode (m e) to show extensions of files #1036

Closed
wants to merge 1 commit into from

Conversation

mikavilpas
Copy link
Contributor

Solves #903

image

@sxyazi
Copy link
Owner

sxyazi commented May 15, 2024

Thanks for the PR, but I don't like solving it in this way:

  • When the file name is fully displayed, two extensions appear, which is a waste of space
  • Still causing unexpected truncation when the filename is long enough (possibly not just the extension, but also the filename)

I want to implement it like "long-file-name.mp4" to be "long-fil~.mp4"

@mikavilpas
Copy link
Contributor Author

I see. Do you think this should be the new default behavior, or toggled on with the linemode setting?

@sxyazi
Copy link
Owner

sxyazi commented May 15, 2024

Yeah it should be the default behavior

@mikavilpas mikavilpas closed this May 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants