Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix headers erasing from response #60

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

Serproger
Copy link
Contributor

Description

Currently ChuckerHttpClient preserves only a status code and a body of the response stripping away other parts of StreamedResponse (for example headers). In particular it can cause incorrect decoding of the response (for example, when the response contains symbols of national alphabets). The given PR addresses this issue.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@syedmurtaza108
Copy link
Owner

Hello @Serproger, thank you for fixing the issue. I can't merge your PR because it is failing one of the unit tests, please see https://github.com/syedmurtaza108/chucker-flutter/actions/runs/6891022076/job/18746529253?pr=60.

@Serproger
Copy link
Contributor Author

Hello @Serproger, thank you for fixing the issue. I can't merge your PR because it is failing one of the unit tests, please see https://github.com/syedmurtaza108/chucker-flutter/actions/runs/6891022076/job/18746529253?pr=60.

As I can see, the failed test has nothing to do with my PR. This test checks the behavior of the interface and tries to tap a control that is located outside interface bounds. Therefore tap doesn't work and value of the preference doesn't change. I can't reproduce it locally, and all the tests are passed successfully, but according to Google, before tapping a widget you should ensure that this widget is visible with something like await tester.ensureVisible(find.byWidget(switches.elementAt(1).widget));. So I would suggest you fixing the wrong test :)

@syedmurtaza108 syedmurtaza108 merged commit b3f646f into syedmurtaza108:master Nov 23, 2023
1 of 2 checks passed
@Serproger
Copy link
Contributor Author

@syedmurtaza108 could you please publish this change as a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants