Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to SIF v2 (master) #112

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Upgrade to SIF v2 (master) #112

merged 1 commit into from
Aug 31, 2021

Conversation

tri-adam
Copy link
Member

@tri-adam tri-adam commented Jun 23, 2021

Replace github.com/sylabs/sif module with github.com/sylabs/sif/v2. Replace deprecated golang.org/x/crypto/openpgp package within forked golang.org/x/crypto module (github.com/sylabs/golang-x-crypto) with github.com/ProtonMail/go-crypto/openpgp. Remove use of deprecated github.com/satori/go.uuid module.

Closes #3. Closes #275.

@tri-adam tri-adam added the dependencies Pull requests that update a dependency file label Jun 23, 2021
@tri-adam tri-adam self-assigned this Jun 23, 2021
@tri-adam tri-adam force-pushed the sif-v2 branch 3 times, most recently from 118ad0a to 7f50dd2 Compare June 29, 2021 20:51
@dtrudg dtrudg added this to the SingularityCE 3.9.0 milestone Jul 2, 2021
@tri-adam tri-adam force-pushed the sif-v2 branch 2 times, most recently from bd81d7e to 7f656e5 Compare July 5, 2021 20:17
@tri-adam tri-adam force-pushed the sif-v2 branch 4 times, most recently from 6420a19 to d8c0bc4 Compare July 30, 2021 19:47
@tri-adam tri-adam force-pushed the sif-v2 branch 14 times, most recently from bd85dd5 to 5e132fc Compare August 13, 2021 14:29
@tri-adam tri-adam force-pushed the sif-v2 branch 3 times, most recently from 25e67b3 to 1e4a3e9 Compare August 26, 2021 01:42
@tri-adam tri-adam force-pushed the sif-v2 branch 7 times, most recently from 7bf1f35 to cbacd60 Compare August 31, 2021 15:33
@tri-adam tri-adam marked this pull request as ready for review August 31, 2021 18:46
@tri-adam tri-adam changed the title Upgrade to SIF v2 Upgrade to SIF v2 (master) Aug 31, 2021
Copy link
Member

@dtrudg dtrudg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, tests pass locally, quick manual exercise works.

Awesome clean up here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Deprecated OpenPGP Package Replace Deprecated UUID Package
2 participants