MNT Fix some unit tests #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
commented
Aug 23, 2024
| $this->orignalReadingMode = Versioned::get_reading_mode(); | ||
| $this->originalReadingMode = Versioned::get_reading_mode(); |
There was a problem hiding this comment.
See line 31 above - this was a typo which resulted in a PHP deprecation warning in CI. Super minor, doesn't really matter until they actually remove the ability to have dynamic properties and it's only a unit test so I don't think it's worth backporting.
GuySartorelli
commented
Aug 23, 2024
Comment on lines
-8
to
-9
| use SilverStripe\ORM\FieldType\DBHTMLText; | ||
| use SilverStripe\Forms\TextField; |
There was a problem hiding this comment.
Neither of these are used
GuySartorelli
commented
Aug 23, 2024
| $this->assertInstanceOf(DBHTMLText::class, $column); | ||
| $this->assertMatchesRegularExpression( | ||
| '/<input type="text" name="TestGridField\[GridFieldEditableColumns\]\[100\]\[Title\]" value="foo"[^>]*>/', | ||
| $column->getValue() | ||
| $column |
There was a problem hiding this comment.
The value for the column comes from forTemplate() which is now typed as string.
Open
23 tasks
emteknetnz
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some unit tests. Comments will explain why the changes were needed.
Issue