-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEW: Task runner better UI #301
NEW: Task runner better UI #301
Conversation
a821602
to
e21b57f
Compare
e21b57f
to
e96c7f0
Compare
Very nice touch! Often these sparingly used areas of the CMS/admin interface don't get any updates/tweaks, so this is refreshing to see. I'd suggest looking at it at the framework level though, if possible, where it lives without the queued jobs additions (run now/enqueue). Here it can subsequently alter the actions. |
Will have a look at the core task runner. Thanks for feedback @michalkleiner |
e96c7f0
to
30e9164
Compare
@michalkleiner Moved some of the code to the framework, please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review comments for framework can be found here but also apply to this PR: silverstripe/silverstripe-framework#9540 (review)
@sachajudd Pushed up new changes based on UI feedback, please review. This is how the UI looks like now: Large screenSmall screen |
See comments on silverstripe/silverstripe-framework#9540 (comment) which apply to this PR 🙂 |
New changes:
|
New changes:
This is now ready for a review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved from a UX perspective 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Mojmir! This PR, along with the core one, is a great step forward for the dev/tasks UI. I've suggested some fairly minor modifications.
I'm also pondering whether it'd be sensible to reduce the code duplication between the base TaskRunner and this one by splitting some of the functionality out into separate methods / config? For example, the stylesheets could be stored in configuration, and the logic for handling them could be split into a method on the base TaskRunner class. This might be overkill, but it might also serve to reduce the amount of double-handling required in future updates to this UI (for example, I'm keen to introduce proper categorisation of tasks later on, along with a search field.)
Let me know what you think.
@Cheddam Pushed up changes as requested, please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, thanks for your contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, one last minor tweak is required 😅
Since we standardised the way the CSS is included in the framework PR, this PR now needs to bump the minimum framework requirement to ^4.7
(the next minor release). I'll tweak this now.
9a49e08
to
4273f6d
Compare
4273f6d
to
0ca00bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I've also rebased onto the 4
branch since this is a new feature, and fixed up Travis config. Once the tests go green we're good to merge 👍
Task runner better UI
Simple UI changes which improve usability of the task runner. Lightweight CSS (no build chain or JS required).
Problem
Current UI
Solution
Proposed UI
Related issues
#302
Dependencies
silverstripe/silverstripe-framework#9540