-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEW Send an email notification when a job is broken #436
Merged
GuySartorelli
merged 1 commit into
symbiote:5
from
creative-commoners:pulls/5/broken-job-email
Jun 27, 2024
Merged
NEW Send an email notification when a job is broken #436
GuySartorelli
merged 1 commit into
symbiote:5
from
creative-commoners:pulls/5/broken-job-email
Jun 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/5/broken-job-email
branch
from
June 24, 2024 02:02
66e7a11
to
405bd43
Compare
emteknetnz
commented
Jun 24, 2024
emteknetnz
force-pushed
the
pulls/5/broken-job-email
branch
from
June 24, 2024 02:17
405bd43
to
41a4d4f
Compare
emteknetnz
commented
Jun 24, 2024
emteknetnz
commented
Jun 24, 2024
emteknetnz
force-pushed
the
pulls/5/broken-job-email
branch
from
June 24, 2024 02:20
41a4d4f
to
bcb57f1
Compare
GuySartorelli
requested changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well locally, just a couple of small things to fix.
emteknetnz
force-pushed
the
pulls/5/broken-job-email
branch
from
June 26, 2024 04:39
bcb57f1
to
46f7e73
Compare
GuySartorelli
requested changes
Jun 26, 2024
emteknetnz
force-pushed
the
pulls/5/broken-job-email
branch
from
June 27, 2024 02:38
46f7e73
to
c515429
Compare
GuySartorelli
requested changes
Jun 27, 2024
emteknetnz
force-pushed
the
pulls/5/broken-job-email
branch
from
June 27, 2024 03:06
c515429
to
dbbcd67
Compare
GuySartorelli
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #435
There is an email sent for 'stalled' jobs, however there is not an email sent for 'broken' jobs. There is existing logic to ensure that there is only a single notification sent, however no email is actually sent, instead the only notification goes to the logger. An inline comment says "email" so looks like the intention all along was to send an email.
Testing steps
Create a vanilla install of silverstripe/installer + this PR
_config/myemail.yml
MyBrokenJob.php
In
admin/queuedjobs
create a new 'My broken job'In console:
vendor/bin/sake dev/tasks/ProcessJobQueueTask
vendor/bin/sake dev/tasks/CheckJobHealthTask
There should be an 'Broken job' email that was sent