Update: comments and test fix for BaseConnection

symblai · May 24, 2022 · cd8a797 · cd8a797
1 parent cee4c87
commit cd8a797
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/api/conversation/Conversation.ts b/src/api/conversation/Conversation.ts
@@ -2,12 +2,15 @@ import {InvalidValueError} from "../../error";
 
 export class Conversation {
 
-
     /**
      * @ignore
      */
     protected conversationId: string;
 
+    /**
+     * Creates Conversation object with conversation id.
+     * @param conversationId string
+     */
     constructor (conversationId: string) {
 
         if (!conversationId || typeof conversationId !== "string") {

diff --git a/tests/connection/Connection.BaseConnection.test.ts b/tests/connection/Connection.BaseConnection.test.ts
@@ -149,10 +149,10 @@ test(
 )
 
 test(
-    "BaseConnection.getConversationId() - returns when it exists",
+    "BaseConnection.getConversationId() - returns null when no conversation exists.",
     () => {
         const connection = new BaseConnection("123456678");
 
-        expect(() => connection.getConversationId()).toThrow(new NullError("There is no stored conversationId."));
+        expect(connection.getConversationId()).toEqual(null);
     }
 )