Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

[WIP] use KnpMenuBundle 2.0 #203

Closed
wants to merge 1 commit into from
Closed

[WIP] use KnpMenuBundle 2.0 #203

wants to merge 1 commit into from

Conversation

lsmith77
Copy link
Member

Q A
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? no
Tests pass? no
Fixed tickets #202, #82, #83, #19
License MIT
Doc PR -

@lsmith77
Copy link
Member Author

see https://github.com/KnpLabs/KnpMenu/blob/master/CHANGELOG.md for the BC breaks in KnpMenu 2.0

@pvgnd
Copy link

pvgnd commented Oct 30, 2014

anybody is working on that ?

@lsmith77
Copy link
Member Author

not that i am aware of. would be awesome if you could pick it up

@pvgnd
Copy link

pvgnd commented Oct 30, 2014

Ok, I'm going to try.
Any recommandations ?

On Thu, Oct 30, 2014 at 4:20 PM, Lukas Kahwe Smith <[email protected]

wrote:

not that i am aware of. would be awesome if you could pick it up


Reply to this email directly or view it on GitHub
#203 (comment)
.

@lsmith77
Copy link
Member Author

check the upgrading guide from KnpMenu and then just switch to the new dep and work through one issue at the time=

@wouterj
Copy link
Member

wouterj commented Oct 30, 2014

Ah, I just started working on this this morning.

@wouterj
Copy link
Member

wouterj commented Oct 30, 2014

If you want to continue/help, @pierrick-vignand , please say. I've enough other things to do :)

@lsmith77
Copy link
Member Author

note I do not think we should contrain ourselves with BC with KnpMenu 1.x .. lets first get 2.0 support going .. if we then realize we can maintain BC with 1.x all the better ..

@wouterj wouterj closed this Nov 1, 2014
@wouterj
Copy link
Member

wouterj commented Nov 1, 2014

Closed in favor of #214

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants