This repository has been archived by the owner on Sep 16, 2021. It is now read-only.
adjust to publish workflow refactoring #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: ContentAwareFactory.php Tests/Unit/ContentAwareFactoryTest.php
| @@ -28,7 +28,7 @@ | |||
| <service id="cmf_menu.factory" class="%cmf_menu.factory_class%"> | |||
| <argument type="service" id="router"/> | |||
| <argument/> <!-- content url generator --> | |||
| <argument type="service" id="cmf_core.publish_workflow_checker"/> | |||
| <argument type="service" id="cmf_core.publish_workflow.checker" on-invalid="ignore"/> | |||
There was a problem hiding this comment.
this is to make the publish workflow optional. alternatively the core bundle could provide a pseudo-publish-workflow when the real publish workflow is deactivated that returns always true to make the bundles never expect a null publish workflow. that could make other components more robust (typo in service name and similar mistakes)
dbu
added a commit
that referenced
this pull request
Jul 15, 2013
adjust to publish workflow refactoring
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adjust to symfony-cmf/core-bundle#59