-
Notifications
You must be signed in to change notification settings - Fork 27
Add option to add paths or route selection to the orginalUrl field #2
Comments
When i say user types into a textbox, i think on the current implementation, where i have created a form type for the admin class. This form type contains this textbox i do not realy like. The question is: how to store the Route to the original content?
|
i think we should have a selection out of the routes that content currently is linked with, to select the correct one. (and most of the time, this should not be relevant anyways, as a content should only have one Route document per locale, all others should be redirects anyways) if you want to handle the situation of several routes at all, i would store the uuid of the route document, as that is least likely to change. |
Yes i think too. If the doc implements the But i wouldn't agree with you that a doc does have only one mapped route. I'm working at a tourism project at work. There i wan't to build documents for the poi's (points of interesst). They are mapped to several categories, which belong to one category group. So i plan to create routes like that:
This is a lot of work for me to hold it in sync, but for this case i would take the default route as the canonical one by default. I just imagine that a extract strategy for routes would make sense too. (#23) |
ah, thanks for the example. i see your point now, why you would have multiple routes. very interesting indeed. will be interesting to get the menu right as well... but with the current menu item voter, should be doable. for the selection, i would only support RouteReferrersReadInterface - if a content does not implement that, you can't generate a URL to it, and manually typing a url is strange - or would you see that as hacky solution to integrate with external systems that handle that url even though its not available in the symfony application? |
To the example: if those poi's will get an own menu entry (mostly seen in some filtered lists) i will make a default route For selecting the route i would like to stay in the cmf system. So if the content implements the But i can imagine a Strategy solution as for titles and descriptions too. |
lets do it without the strategy i would say, to not overcomplicate. if we realize it needs more complexity, we can still expand. |
Ok. I think i will do that this evening when implementing the test for the admin extension. |
I am struggling with my self why not delay this to the next version. It is just a feature, won't cause any BC-breaks. I i got time on Friday/Saturday i will do it, but can be delayed or? |
lets focus on releasing 1.0 - we can follow with a 1.1 in a month if there is a lot of new interesting stuff... and we will notice issues in the real live i am sure, and then change some thing or other. |
remove the milestone? or just close this? |
i would just remove the mile stone, as that one would be a nice feature
to select routes for the canocical route or the redirect route.
|
instead of setting string url's to the
SeoMetadata
i would prefere the routes selection from the treebrowser for setting the redirect/canonical url.The text was updated successfully, but these errors were encountered: