This repository has been archived by the owner on Sep 16, 2021. It is now read-only.
Add SeoBundle twig extension documentation #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
benglass
commented
Sep 22, 2015
benglass
commented
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes (symfony-cmf/seo-bundle#263) |
| Applies to | SeoBundle master/1.2 |
3 tasks
|
|
||
| This bundle provides a twig function ``cmf_seo_update_seo_page`` | ||
| which lets you set the object which should be used to populate | ||
| the seo page. For details on how this works, read :doc:`introduction`. |
| The twig extension was added in SeoBundle 1.2. | ||
|
|
||
| This bundle provides a twig function ``cmf_seo_update_metadata`` | ||
| which lets you set the object which should be used to populate |
There was a problem hiding this comment.
is it changing the object or does it just extract information from that object, in addition to what it already extracted from previous objects?
|
please also add a note in the documentation about extracting the metadata that mentions the twig functions in case documents are looped over in twig or otherwise not yet available in the controller. |
| The twig extension was added in SeoBundle 1.2. | ||
|
|
||
| This bundle provides a twig function ``cmf_seo_update_metadata`` | ||
| which lets you populate the seo page from an object. |
There was a problem hiding this comment.
@dbu I reworded this per your comment.
benglass
force-pushed
the
add_twig_extension_update_seo_page_docs
branch
from
952b224 to
a7e8ad8
Compare
| {% extends 'base.html.twig' %} | ||
|
|
||
| {% block metadata %} | ||
| {{ cmf_seo_update_metadata(post) }} |
There was a problem hiding this comment.
@dbu Removed the do, you caught me trying to be clever.
dbu
added a commit
that referenced
this pull request
Oct 1, 2015
…o_page_docs Add SeoBundle twig extension documentation
|
thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.