Add priority field to processor tags #485
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94noni
reviewed
Jul 30, 2024
| public function process(ContainerBuilder $container) | ||
| { | ||
| if (!$container->hasDefinition('monolog.logger')) { | ||
| return; | ||
| } | ||
|
|
||
| foreach ($container->findTaggedServiceIds('monolog.processor') as $id => $tags) { | ||
| foreach (array_reverse($this->findAndSortTaggedServices('monolog.processor', $container)) as $reference) { |
There was a problem hiding this comment.
perhaps comment why array_reverse is used ?
otherwise its smart :)
94noni
approved these changes
Jul 30, 2024
So that the order in which the processors are used by monolog can be determined.
stof
reviewed
Oct 8, 2024
| public function process(ContainerBuilder $container) | ||
| { | ||
| if (!$container->hasDefinition('monolog.logger')) { | ||
| return; | ||
| } | ||
|
|
||
| foreach ($container->findTaggedServiceIds('monolog.processor') as $id => $tags) { | ||
| // array_reverse is used because ProcessableHandlerTrait::pushProcessor prepends processors to the beginning of the stack | ||
| foreach (array_reverse($this->findAndSortTaggedServices('monolog.processor', $container)) as $reference) { |
There was a problem hiding this comment.
how does this behave when we have multiple tags (for instance when registering the processor in specific channels or in specific handlers ?
There was a problem hiding this comment.
@stof Good catch, it didn't work. I've managed to fix it. Please let me know what you think of the fix. It's probably easiest to review it with whitespace changes ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #455.