Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test with symfony/config:^7.2 #495

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

alexandre-daubois
Copy link
Contributor

@alexandre-daubois alexandre-daubois commented Nov 4, 2024

Following symfony/symfony#58490 (comment). Until the Symfony PR, null wasn't supported in boolean nodes and defaulted to true.

@derrabus
Copy link
Member

derrabus commented Nov 4, 2024

Thank you. Your change makes our test suite green again, which is great of course. But, are we sure this subtle change in behavior won't break stuff downstream?

@alexandre-daubois
Copy link
Contributor Author

alexandre-daubois commented Nov 4, 2024

I had a look while creating the PR, and it seems the null possibility was actually handled, even if not possible until now :

if (null === $handler['process_psr_3_messages']['enabled']) {
$handler['process_psr_3_messages']['enabled'] = !isset($handler['handler']) && !$handler['members'];
}

@derrabus
Copy link
Member

derrabus commented Nov 6, 2024

Thank you @alexandre-daubois.

@derrabus derrabus merged commit b0a559d into symfony:master Nov 6, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants