Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use own exception hierarchy #642

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use own exception hierarchy #642

wants to merge 2 commits into from

Conversation

OskarStark
Copy link
Contributor

@OskarStark OskarStark commented Oct 2, 2024

Should be merged after

@OskarStark OskarStark self-assigned this Oct 2, 2024
@nicolas-grekas
Copy link
Member

rebase needed indeed :)

@wouterj
Copy link
Member

wouterj commented Oct 3, 2024

We used to say that Symfony components deserve their own exception hierarchy for runtime exceptions, but not for logic exceptions. The reason being that the latter are a logic error which should never be caught and must be fixed for the code to work at all.

@OskarStark
Copy link
Contributor Author

OskarStark commented Oct 3, 2024

We used to say that Symfony components deserve their own exception hierarchy for runtime exceptions, but not for logic exceptions. The reason being that the latter are a logic error which should never be caught and must be fixed for the code to work at all.

I double checked symfony/symfony before opening this PR and the Asset, BrowserKit and Console components (stopped checking further components then TBH) uses exactly these ones: RuntimeException, LogicException and InvalidArgumentException, so I just followed this path 🤷‍♂️

@OskarStark
Copy link
Contributor Author

Rebased

@OskarStark
Copy link
Contributor Author

Will fix Tests on Monday

@OskarStark OskarStark added the enhancement New feature or request label Oct 7, 2024
@OskarStark
Copy link
Contributor Author

Failures look unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants