-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use own exception hierarchy #642
base: main
Are you sure you want to change the base?
Conversation
rebase needed indeed :) |
We used to say that Symfony components deserve their own exception hierarchy for runtime exceptions, but not for logic exceptions. The reason being that the latter are a logic error which should never be caught and must be fixed for the code to work at all. |
I double checked |
7961853
to
bc90c44
Compare
fc51e59
to
e9b5b46
Compare
Rebased |
Will fix Tests on Monday |
Failures look unrelated |
Should be merged after