-
-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FOS User Bundle recipe #345
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request does not pass validation.
"MAILER_SENDER_ADDRESS": "[email protected]", | ||
"MAILER_SENDER_NAME": "John Doe" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should end with a newline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
Waiting for FriendsOfSymfony/FOSUserBundle#2780 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR.
It seams to be a duplicate of #345. We should work together with that PR to decide how to move forward.
|
||
See https://symfony.com/doc/master/bundles/FOSUserBundle/index.html | ||
|
||
1. Step 3: Create your User class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add this in the recipe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This very use case specific. i think, the developer should create the user class on his own
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but we could help the user. We could create a class named User
that implements the interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can do that
See https://symfony.com/doc/master/bundles/FOSUserBundle/index.html | ||
|
||
1. Step 3: Create your User class | ||
2. Step 4: Configure your application\'s security.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also do this in the recipe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... I don't see any way to modify the application's security.yaml
through the recipe. Do you've any idea to solve that?
2. Step 4: Configure your application\'s security.yml | ||
(config/packages/security.yaml) | ||
|
||
3. Step 6: Import FOSUserBundle routing files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be done in in the recipe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Before I get back to work i'll wait for the merge of my pull request from above
Hi there is no activity in #270 because like you I wait that the If you want to see a recipe for FOSUserBundle take a look and show your support by 👍 on : |
Closing as a duplicate (#270) |
Since there is no more activity in #270 and my other PR (#210) was closed I'm creating this one