WIP: Reintroduce FOSUserBundle #656
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deployed
to
|
Depends on FriendsOfSymfony/FOSUserBundle#2708 |
Initially added in symfony#270 and reverted in symfony#655
|
We are waiting for FriendsOfSymfony/FOSUserBundle#2708 |
Nyholm
commented
Apr 11, 2019
| @@ -0,0 +1,10 @@ | |||
| fos_user: | |||
| db_driver: no_driver # valid values are 'orm', 'mongodb' and 'couchdb' | |||
There was a problem hiding this comment.
This is not yet supported.
|
I think we have a problem here. One side, we don't want to pre-config the db_driver to orm. But at the other side, we are includin a User entity that uses ORM annotations, that requires doctrine/orm. I think we have two options right now. One, set default db_driver to orm, and configure a the recipe according. The other, create a new meta-package, fosuserbundle-orm, that requires fosuserbundle and doctrine-bundle, and create a new recipe for this new meta-package that can be configured to use orm as db_driver. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially added in #270 and reverted in #655