Fix: update guest setting need reload (#193)

synctv-org · Jun 22, 2024 · 8798ac5 · 8798ac5
1 parent a4b2e81
commit 8798ac5
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/internal/op/room.go b/internal/op/room.go
@@ -509,18 +509,21 @@ func (r *Room) SetSettings(settings *model.RoomSettings) error {
 	if err != nil {
 		return err
 	}
-	r.Settings = settings
-	if settings.DisableGuest {
-		return r.KickUser(db.GuestUserID)
-	}
-	return nil
+	return r.afterUpdateSettings(settings)
 }
 
 func (r *Room) UpdateSettings(settings map[string]any) error {
 	rs, err := db.UpdateRoomSettings(r.ID, settings)
 	if err != nil {
 		return err
 	}
+	return r.afterUpdateSettings(rs)
+}
+
+func (r *Room) afterUpdateSettings(rs *model.RoomSettings) error {
+	if r.Settings.GuestPermissions != rs.GuestPermissions {
+		r.members.Delete(db.GuestUserID)
+	}
 	r.Settings = rs
 	if rs.DisableGuest {
 		return r.KickUser(db.GuestUserID)